Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ticket/12025] Post Preview no longer shows warnings #2360

Merged
merged 4 commits into from
May 8, 2014
Merged

[ticket/12025] Post Preview no longer shows warnings #2360

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0ef920e
[ticket/12025] Post Preview no longer shows warnings
Nicofuma Apr 26, 2014
8facf2b
[ticket/12025] Don't show any error on preview if the message is empty
Nicofuma Apr 27, 2014
7af9f41
[ticket/12025] Fixing the condition....
Nicofuma Apr 28, 2014
0061067
[ticket/12025] Apply DeMorgan
Nicofuma May 5, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions phpBB/posting.php
View file
Open in desktop
Expand Up @@ -879,10 +879,13 @@
$message_parser->warn_msg = array();
}

$message_parser->parse($post_data['enable_bbcode'], ($config['allow_post_links']) ? $post_data['enable_urls'] : false, $post_data['enable_smilies'], $img_status, $flash_status, $quote_status, $config['allow_post_links']);
if (! ($preview && empty($message_parser->message)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the ! into the brackets

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply DeMorgan.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (!$preview || !empty($message_parser->message))

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

{
$message_parser->parse($post_data['enable_bbcode'], ($config['allow_post_links']) ? $post_data['enable_urls'] : false, $post_data['enable_smilies'], $img_status, $flash_status, $quote_status, $config['allow_post_links']);
}

// On a refresh we do not care about message parsing errors
if (sizeof($message_parser->warn_msg) && $refresh)
if (sizeof($message_parser->warn_msg) && $refresh && !$preview)
{
$message_parser->warn_msg = array();
}
Expand Down