[ticket/12488] Add user warning indication to viewtopic posts #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -129,6 +129,7 @@ <h2 class="poll-title">{POLL_QUESTION}</h2> | |||
|
|
|||
| <!-- IF postrow.POSTER_POSTS != '' --><dd class="profile-posts"><strong>{L_POSTS}{L_COLON}</strong> {postrow.POSTER_POSTS}</dd><!-- ENDIF --> | |||
| <!-- IF postrow.POSTER_JOINED --><dd class="profile-joined"><strong>{L_JOINED}{L_COLON}</strong> {postrow.POSTER_JOINED}</dd><!-- ENDIF --> | |||
| <!-- IF postrow.POSTER_WARNINGS --><dd class="profile-warnings"><strong>{L_WARNINGS}{L_COLON}</strong> <em>{postrow.POSTER_WARNINGS}</em></dd><!-- ENDIF --> | |||
There was a problem hiding this comment.
the value should not be wrapped by <em>
PHPBB3-12488
|
@bantu : it's already in place: https://github.com/phpbb/phpbb/blob/develop-ascraeus/phpBB/viewtopic.php#L1135 so I'll just remove the @nickvergessen : what would be the use of a non-permission based value? Secondly, which one should be the default |
Don't know what I was thinking with this PHPBB3-12488
nickvergessen
added a commit
to nickvergessen/phpbb
that referenced
this pull request
May 7, 2014
[ticket/12488] Add user warning indication to viewtopic posts * PayBas/ticket/12488: [ticket/12488] subSilver2 fix (no longer displays if warnings = 0) [ticket/12488] Typo fix [ticket/12488] Removed <em> and removed anonymous check [ticket/12488] Add user warning indication to viewtopic posts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tracker.phpbb.com/browse/PHPBB3-12488
http://area51.phpbb.com/phpBB/viewtopic.php?f=108&t=45517
PHPBB3-12488