Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/12606] Add ACP group core events #2518

Merged
merged 1 commit into from Jun 9, 2014

Conversation

Pico
Copy link
Contributor

@Pico Pico commented May 30, 2014

'group_id',
'group_row',
'error',
'template_data',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

template_data should not be required. You can simply use template->assign_vars() yourself.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add group_desc_data, group_name, group_type, group_rank, rank_options

@Pico
Copy link
Contributor Author

Pico commented May 30, 2014

Updated. Now I think if it require 3 events or just use 2 (remove the first one).

'group_rank',
'rank_options',
'error',
);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing template_data? The other two events have their arrays included.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I missed that somehow. Thanks!

@Pico
Copy link
Contributor Author

Pico commented May 30, 2014

Updated and rebased.

'allow_desc_urls',
'allow_desc_smilies',
'submit_ary',
'test_variables'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing , at end of line:

There was 1 error:

  1. phpbb_event_export_php_test::test_crawl_php_file with data set [ticket/10040] Enable error_reporting on PHP 5.2 in test suite #112 ('includes/acp/acp_groups.php')
    LogicException: Found invalid var 'test_variables, 'submit_ary' in array for event 'core.acp_manage_group_initialise_data' in file 'includes/acp/acp_groups.php:514'

@nickvergessen
Copy link
Contributor

Please either merge all the commits into one, or give them unique commit messages describing what each commit changed

@Pico
Copy link
Contributor Author

Pico commented Jun 9, 2014

Updated and merged to 1 commit

nickvergessen added a commit to nickvergessen/phpbb that referenced this pull request Jun 9, 2014
[ticket/12606] Add ACP group core events

* Pico88/ticket/12606:
  [ticket/12606] Add ACP group core events
@nickvergessen nickvergessen merged commit 74842b2 into phpbb:develop-ascraeus Jun 9, 2014
@Pico Pico deleted the ticket/12606 branch October 12, 2014 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants