[ticket/12649] Change sort & display options in footers to dropdown menu #2541
Conversation
|
I'm not sure about this particular change. Hiding multiple drop-down menus in another drop-down menu? I think this one may be going a bit too far with all the button-menus. It's just hiding menus in a place that is not obvious. I think these topic sort tools were much more effective as they were. |
|
It wasn't necessarily my idea. The reasoning is that these items are a major eyesore, and take up quite a lot of UI space. And 99% of users will never touch them in their lives. On most of my boards I simply hide them completely, and in all these years I haven't had a single(!) remark that something was missing. |
|
More efficient yes, but also more clutter. |
|
Should we just add this into the topic tools thing? Just like the option to download all attachments? |
|
I don't think we should be doing this to the topic sort tools at all IMO. |
|
These display options are present on a lot of pages. Way more than topic-tools. Whereas the benefits on viewforum and viewtopic might be minor, this PR greatly reduces the already overcrowded MCP. It was prototech's idea. He was working on the new CSS jumpbox and quick-mod. This PR fits those upcoming changes nicely. Keep in mind though that the screenshot is just a quickie. I didn't really get around to styling it yet, because it depends on other PRs. |
| <!-- IF S_VIEWFORUM --> | ||
| <form method="post" action="{S_FORUM_ACTION}"> | ||
| <!-- ELSEIF S_VIEWTOPIC --> | ||
| <form id="viewtopic" method="post" action="{S_TOPIC_ACTION}"> |
There was a problem hiding this comment.
Not sure why this one has an id. I searched through all the CSS and JS files and can't find any instance where it's actually referred to.
PayBas
changed the title
PayBas
changed the title
| <!-- ENDIF --> | ||
| <hr class="dashed" /> | ||
| <!-- IF S_IN_MCP and TOPIC_ID --> | ||
| <label><input type="checkbox" class="radio" name="t" value="{TOPIC_ID}" checked="checked" /> <strong>{L_ONLY_TOPIC}</strong></label> |
There was a problem hiding this comment.
I'm actually not really sure what this does. I haven't been able to get it to show.
There was a problem hiding this comment.
Click on the MCP link whilst in a topic, then go to the Moderation queue tab and it'll show.
|
I think it would be a nice idea to add a button to save the settings as new default settings. |
|
@nickvergessen so that would be a checkbox below the If it's checked, upon form submit, it will go to the UCP, change the settings, and automatically redirect back to the topic/forum we were viewing? |
|
I would go with a new button instead of a check box. |
|
This change work good in phpbb 3.1.0 rc4? |
|
@VOLKERMORD this needs to be updated first |
nickvergessen
changed the title
PHPBB3-12649
PHPBB3-12649
PHPBB3-12649
naderman
force-pushed
the
develop-ascraeus
branch
from
61ad400
to
0e772af
Compare
|
bump @PayBas @nickvergessen |
|
While I don't like hiding too much stuff, this is one of the least used features on the viewtopic page so I'm all for adding this drop down. |
|
This had alot of controversy in its UI implimentation and no one could agree upon a solution. But when I get some time over the weekend I will rebase it if I can as I know its complete as @PayBas included it in his theme. |
https://tracker.phpbb.com/browse/PHPBB3-12649
Somewhat depends on #2504 for icons.