Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ticket/12735] Remove all :link, :visited, :active states #2613

Merged
merged 7 commits into from Jul 4, 2014
Merged

[Ticket/12735] Remove all :link, :visited, :active states #2613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7d04d95
[ticket/12735] Remove all :link, :visited, :active states
hanakin Jun 18, 2014
194224b
[ticket/12735] Undo selector rename
hanakin Jun 18, 2014
8ef8056
[ticket/12735] Remove underlines by default
hanakin Jun 22, 2014
bf3ac9b
[ticket/12735] Fix some color incosistencies
hanakin Jun 22, 2014
710e0e7
[ticket/12732] Undo search-box change
hanakin Jun 24, 2014
20e9480
[ticket/12735] Fix line breaks
hanakin Jun 25, 2014
5783b00
[ticket/12735] Remove unnecessary span
hanakin Jun 30, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
77 changes: 8 additions & 69 deletions phpBB/styles/prosilver/theme/colours.css
View file
Open in desktop
Expand Up @@ -241,61 +241,22 @@ Colours and backgrounds for links.css
-------------------------------------------------------------- */

a { color: #105289; }
a:visited { color: #105289; }
a:hover { color: #D31141; }
a:active { color: #368AD2; }

/* Links on gradient backgrounds */
#search-box a:link, .navbg a:link, .forumbg .header a:link, .forabg .header a:link, th a:link {
color: #FFFFFF;
}

#search-box a:visited, .navbg a:visited, .forumbg .header a:visited, .forabg .header a:visited, th a:visited {
#search-box a, .navbg a, .forumbg .header a, .forabg .header a, th a {
color: #FFFFFF;
}

#search-box a:hover, .navbg a:hover, .forumbg .header a:hover, .forabg .header a:hover, th a:hover {
color: #A8D8FF;
}

#search-box a:active, .navbg a:active, .forumbg .header a:active, .forabg .header a:active, th a:active {
color: #C8E6FF;
}

/* Notification mark read link */
.dropdown-extended a.mark_read {
background-color: #FFFFFF;
}

/* Links for forum/topic lists */
a.forumtitle {
color: #105289;
}

/* a.forumtitle:visited { color: #105289; } */

a.forumtitle:hover {
color: #BC2A4D;
}

a.forumtitle:active {
color: #105289;
}

a.topictitle {
color: #105289;
}

/* a.topictitle:visited { color: #368AD2; } */

a.topictitle:hover {
color: #BC2A4D;
}

a.topictitle:active {
color: #105289;
}

/* Post body links */
.postlink {
color: #368AD2;
Expand All @@ -307,7 +268,7 @@ a.topictitle:active {
border-bottom-color: #5D8FBD;
}

.postlink:active {
.postlink {
color: #368AD2;
}

Expand All @@ -316,32 +277,10 @@ a.topictitle:active {
color: #0D4473;
}

.signature a, .signature a:visited, .signature a:hover, .signature a:active {
.signature a, .signature a:hover {
background-color: transparent;
}

/* Profile links */
.postprofile a:link, .postprofile a:visited, .postprofile dt.author a {
color: #105289;
}

.postprofile a:hover, .postprofile dt.author a:hover {
color: #D31141;
}

.postprofile a:active {
color: #105289;
}

/* Profile searchresults */
.search .postprofile a {
color: #105289;
}

.search .postprofile a:hover {
color: #D31141;
}

/* Back to top of page */
a.top {
background-image: url("./images/icon_back_top.gif");
Expand Down Expand Up @@ -658,7 +597,7 @@ dd.profile-warnings {
--------------------------------------------------------------
Colours and backgrounds for buttons.css
-------------------------------------------------------------- */
.button, .button:visited {
.button {
border-color: #C7C3BF;
background-color: #FFFFFF;
background-image: -moz-linear-gradient(top, #FFFFFF, #E9E9E9);
Expand All @@ -668,7 +607,7 @@ Colours and backgrounds for buttons.css
-ms-filter: "progid:DXImageTransform.Microsoft.gradient(startColorStr='#FFFFFF', EndColorStr='#E9E9E9')";
box-shadow: 0 0 0 1px #FFFFFF inset;
-webkit-box-shadow: 0 0 0 1px #FFFFFF inset;
color: #BC2A4D;
color: #D31141;
}

.button:hover, .dropdown-visible .dropdown-select, .nojs .dropdown-container:hover .dropdown-select {
Expand Down Expand Up @@ -814,7 +753,7 @@ ul.cplist {

#tabs .tab > a:hover {
background: #DDEDFB;
color: #BC2A4D;
color: #D31141;
}

#tabs .activetab > a,
Expand Down Expand Up @@ -855,7 +794,7 @@ ul.cplist {
}

.responsive-tab .responsive-tab-link:hover:before {
border-color: #BC2A4D;
border-color: #D31141;
}

/* UCP navigation menu
Expand Down Expand Up @@ -1079,7 +1018,7 @@ a.button2, input.button2, input.button3 {
}

/* <a> button in the style of the form buttons */
a.button1, a.button1:link, a.button1:visited, a.button1:active, a.button2, a.button2:link, a.button2:visited, a.button2:active {
a.button1, a.button2 {
color: #000000;
}

Expand Down
8 changes: 4 additions & 4 deletions phpBB/styles/prosilver/theme/common.css
View file
Open in desktop
Expand Up @@ -912,14 +912,14 @@ fieldset.fields1 dl.pmlist dd.recipients {
.phpbb_alert {
border: 1px solid transparent;
display: none;
left: 0;
left: 0;
padding: 0 25px 20px 25px;
position: fixed;
right: 0;
right: 0;
top: 150px;
z-index: 50;
width: 620px;
margin: 0 auto;
margin: 0 auto;
}

@media only screen and (max-height: 500px), only screen and (max-device-width: 500px)
Expand Down Expand Up @@ -1143,7 +1143,7 @@ form > p.post-notice strong {
font-size: 11px;
font-weight: bold;
text-shadow: 1px 1px 1px white;
text-transform: uppercase;
text-transform: uppercase;
line-height: 30px;
border-bottom: 1px solid;
border-radius: 5px 5px 0 0;
Expand Down
47 changes: 11 additions & 36 deletions phpBB/styles/prosilver/theme/links.css
View file
Open in desktop
Expand Up @@ -5,19 +5,10 @@
a {
direction: ltr;
unicode-bidi: embed;
}

a:link, a:visited {
text-decoration: none;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The selector should be changed to a instead of removing the rule altogether. Most links have an underline now because of this.

a:hover {
text-decoration: underline;
}

a:active {
text-decoration: none;
}
a:hover { text-decoration: underline; }

/* Coloured usernames */
.username-coloured {
Expand All @@ -27,22 +18,14 @@ a:active {
}

/* Links on gradient backgrounds */
#search-box a:link, .navbg a:link, .forumbg .header a:link, .forabg .header a:link, th a:link {
text-decoration: none;
}

#search-box a:visited, .navbg a:visited, .forumbg .header a:visited, .forabg .header a:visited, th a:visited {
#search-box a, .navbg a, .forumbg .header a, .forabg .header a, th a {
text-decoration: none;
}

#search-box a:hover, .navbg a:hover, .forumbg .header a:hover, .forabg .header a:hover, th a:hover {
text-decoration: underline;
}

#search-box a:active, .navbg a:active, .forumbg .header a:active, .forabg .header a:active, th a:active {
text-decoration: none;
}

/* Navigation bar links */
ul.linklist li.small-icon > a, ul.linklist li.breadcrumbs span:first-child > a {
display: inline-block;
Expand Down Expand Up @@ -118,13 +101,13 @@ a.lastsubject:hover {
text-decoration: none;
}

.signature a, .signature a:visited, .signature a:hover, .signature a:active {
.signature a, .signature a:hover {
border: none;
text-decoration: underline;
}

/* Profile links */
.postprofile a:link, .postprofile a:visited, .postprofile dt.author a {
.postprofile a, .postprofile dt.author a {
font-weight: bold;
text-decoration: none;
}
Expand All @@ -133,22 +116,14 @@ a.lastsubject:hover {
text-decoration: underline;
}

/* CSS spec requires a:link, a:visited, a:hover and a:active rules to be specified in this order. */
/* See http://www.phpbb.com/bugs/phpbb3/59685 */
.postprofile a:active {
font-weight: bold;
text-decoration: none;
}


/* Profile searchresults */
/* Profile searchresults */
.search .postprofile a {
text-decoration: none;
text-decoration: none;
font-weight: normal;
}

.search .postprofile a:hover {
text-decoration: underline;
text-decoration: underline;
}

/* Back to top of page */
Expand Down Expand Up @@ -182,7 +157,7 @@ a.arrow-down { background: none no-repeat right center; }
a.arrow-left { background: none no-repeat 3px 60%; }
a.arrow-right { background: none no-repeat 95% 60%; }

a.arrow-up, a.arrow-up:link, a.arrow-up:active, a.arrow-up:visited {
a.arrow-up {
padding-left: 10px;
text-decoration: none;
border-bottom-width: 0;
Expand All @@ -192,7 +167,7 @@ a.arrow-up:hover {
background-position: left top;
}

a.arrow-down, a.arrow-down:link, a.arrow-down:active, a.arrow-down:visited {
a.arrow-down {
padding-right: 10px;
}

Expand All @@ -201,7 +176,7 @@ a.arrow-down:hover {
text-decoration: none;
}

a.arrow-left, a.arrow-left:active, a.arrow-left:visited {
a.arrow-left {
padding-left: 12px;
}

Expand All @@ -210,7 +185,7 @@ a.arrow-left:hover {
background-position: 0 60%;
}

a.arrow-right, a.arrow-right:active, a.arrow-right:visited {
a.arrow-right {
padding-right: 12px;
}

Expand Down