[ticket/12787] Allow the route to say that the referer has to be used. #2676
Conversation
|
There has been a previous patch using referer. The referer is not an acceptable solution as it might just be off. |
| @@ -111,6 +119,33 @@ public function getController(Request $request) | |||
| } | |||
| } | |||
|
|
|||
| // If the request is made by ajax and if requested, fix the request_uri to use the referer. | |||
| // If the request has an _referer attribute it is used, otherwise we use the request header if available. | |||
| if ($request->isXmlHttpRequest() && $request->get('_ajax_fix_request_uri', false) && $request instanceof \phpbb\symfony_request) | |||
|
i didn't find another solution because we need the real request_uri for the route matcher and the easiest way to get the value is to use the referer (here as a fallback if the referer isn't specified as argument in the query). But we could remove this fallback yes... |
|
Please dig up the other PR. |
|
PR is useless as I rebased, here is the branch before rebase: |
If the current request is a AJAX we need to fix the paths. We need to get the root path based on the Referer, so we can use the generated URLs in the template of the Referer. If we do not generate the relative path based on the Referer, but based on the currently requested URL, the generated URLs will not point to the intended locations: Referer desired URL desired relative root path memberlist.php faq.php ./ memberlist.php app.php/foo/bar ./ app.php/foo memberlist.php ../ app.php/foo app.php/fox ../ app.php/foo/bar memberlist.php ../../ ../page.php memberlist.php ./phpBB/ ../sub/page.php memberlist.php ./../phpBB/ PHPBB3-12099
PHPBB3-12099
PHPBB3-12787
|
@nickvergessen I think there was a description of a proper solution in that PR. |
|
@nickvergessen There you go. #2427 (comment) |
|
about this i think that it should be an other PR (a generalization of this one which allows a request to define the refer to use) |
|
bump |
|
You have an ext ready for testing? |
|
only the profiler which needs another PRs... (the links in the toolbar: http://phpbb3-1.nicofuma.fr/upstream/demo/world) |
|
The URL which use the referer is in the ajax call at the end of the HTML code and this ajax call generate the toolbar (with the links) |
…ot_path PHPBB3-12787
|
updated |
|
Created a new branch in the acme/demo which tests ranks, smilies (put one in your signature) and normal links: |
|
|
|
Results of the app should be verified on:
|
[ticket/12787] Allow the route to say that the referer has to be used. * Nicofuma/ticket/12787: [ticket/12787] Updates phpbb_mock_controller_helper [ticket/12787] Add controller_helper::get_current_url() [ticket/12787] Remove one app.php when it's both in $path and $web_root_path [ticket/12787] Fix the absolute board url [ticket/12787] Use a parameter (_referer) instead of the Referer header [ticket/12099] Add unit tests for get_web_root_path_from_ajax_referer() [ticket/12099] Remove config again [ticket/12099] Correctly fix the path when performing AJAX requests [ticket/12099] Add request argument to path_helper service
https://tracker.phpbb.com/browse/PHPBB3-12787
PHPBB3-12787