Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/12813] Improve responsive pagination alignment and page-jump fixes #2696

Merged
merged 4 commits into from Jul 7, 2014

Conversation

PayBas
Copy link
Contributor

@PayBas PayBas commented Jul 5, 2014

  1. Fix incorrect title attribute on page-jump input element
  2. Remove empty value attribute on page-jump input element
  3. Use input type="number" for page-jump
  4. Reduce the number of page elements in the topic-row pagination
  5. Reposition topic-row pagination on the same line as "replies", thereby giving more room to the last-post info.

https://tracker.phpbb.com/browse/PHPBB3-12813

@@ -276,6 +276,10 @@ textarea.inputbox {
width: auto !important;
}

input[type="number"] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we really do this for all input fields?
Or better just this one field you need it for.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opted for this due to a FF bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1024078

spinner

But I guess it will be fixed eventually, so there won't really be need for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: I decided to use -moz-padding-end: inherit; instead. So this is now a FF-only fix.

@PayBas PayBas changed the title [WIP][ticket/12813] Improve responsive pagination alignment and page-jump fixes [ticket/12813] Improve responsive pagination alignment and page-jump fixes Jul 6, 2014
@prototech prototech merged commit b323a01 into phpbb:develop-ascraeus Jul 7, 2014
@PayBas PayBas deleted the ticket/12813 branch July 7, 2014 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants