Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ticket/12891] Replace template loops with 1 loop to reduce generation time #2778

Merged
merged 1 commit into from
Jul 28, 2014
Merged

[ticket/12891] Replace template loops with 1 loop to reduce generation time #2778

merged 1 commit into from
Jul 28, 2014

Conversation

nickvergessen
Copy link
Contributor

https://tracker.phpbb.com/browse/PHPBB3-12891

Reduced load time with 5k entries from ~20secs to ~7secs

@Elsensee
Copy link
Contributor

Missing changes for mcp_ban.php?

@nickvergessen
Copy link
Contributor Author

No, mcp_ban.php calls acp_ban:
https://github.com/phpbb/phpbb/blob/develop-ascraeus/phpBB/includes/mcp/mcp_ban.php#L137

@marc1706 marc1706 merged commit 75aef80 into phpbb:develop-ascraeus Jul 28, 2014
@nickvergessen nickvergessen deleted the ticket/12891 branch January 10, 2015 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nickvergessen @Elsensee @marc1706