Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/12942] Add core.add_form_key core event #2845

Merged
merged 1 commit into from Aug 11, 2014

Conversation

@rxu
Copy link
Contributor

rxu commented Aug 9, 2014

Add core.add_form_key core event to allow extensions modifying
form key.

PHPBB3-12942.

@nickvergessen nickvergessen added the Event label Aug 9, 2014
'now',
's_fields',
'token',
'token_sid',

This comment has been minimized.

Copy link
@nickvergessen

nickvergessen Aug 10, 2014

Contributor

add form_name please

@rxu

This comment has been minimized.

Copy link
Contributor Author

rxu commented Aug 10, 2014

@nickvergessen Added form_name.

nickvergessen added a commit to nickvergessen/phpbb that referenced this pull request Aug 10, 2014
[ticket/12942] Add core.add_form_key core event

* rxu/ticket/12942:
  [ticket/12942] Add core.add_form_key core event
* Perform additional actions on creation form token
*
* @event core.add_form_key
* @var int form_name The form name

This comment has been minimized.

Copy link
@marc1706

marc1706 Aug 10, 2014

Member

form_name is a string

@@ -2551,6 +2551,27 @@ function add_form_key($form_name)
'form_token' => $token,
));
/**
* Perform additional actions on creation form token

This comment has been minimized.

Copy link
@marc1706

marc1706 Aug 10, 2014

Member

*creation of form token

* @event core.add_form_key
* @var int form_name The form name
* @var int now Current time timestamp
* @var string s_fields Generated hidden fields

This comment has been minimized.

Copy link
@marc1706

marc1706 Aug 10, 2014

Member

s_fields is an array

This comment has been minimized.

Copy link
@rxu

rxu Aug 10, 2014

Author Contributor

The result of _build_hidden_fields is a string.

This comment has been minimized.

Copy link
@marc1706

marc1706 Aug 11, 2014

Member

Sorry, my bad.

Add core.add_form_key core event to allow extensions modifying
form key.

PHPBB3-12942
@rxu

This comment has been minimized.

Copy link
Contributor Author

rxu commented Aug 10, 2014

Updated #2845.

marc1706 added a commit to marc1706/phpbb that referenced this pull request Aug 11, 2014
[ticket/12942] Add core.add_form_key core event
@marc1706 marc1706 merged commit b20af9a into phpbb:develop-ascraeus Aug 11, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.