[ticket/12961] Add link in anti-spam ACP page which links directly to captchas in titania #2875
Conversation
As per IRC suggestion PHPBB3-12961
| @@ -298,6 +298,8 @@ | |||
| // Visual Confirmation Settings | |||
| $lang = array_merge($lang, array( | |||
| 'ACP_VC_SETTINGS_EXPLAIN' => 'Here you can select and configure plugins, which are designed to block automated form submissions by spambots. These plugins typically work by challenging the user with a <em>CAPTCHA</em>, a test which is designed to be difficult for computers to solve.', | |||
| 'ACP_VC_EXT_GET_MORE' => 'For additional (and possibly better) anti-spam plugins, visit the', | |||
There was a problem hiding this comment.
Should be For additional (and possibly better) anti-spam plugins, visit the %sphpBB.com anti-spam extensions database%s',
Instead.
Then sprintf the link into it via php and put it into the template.
The way you do it now will not work for a lot of translations
PHPBB3-12961
| @@ -61,6 +61,9 @@ function main($id, $mode) | |||
|
|
|||
| $this->tpl_name = 'acp_captcha'; | |||
| $this->page_title = 'ACP_VC_SETTINGS'; | |||
| $template->assign_vars(array(L_ACP_VC_EXT_GET_MORE => sprintf($user->lang['ACP_VC_EXT_GET_MORE'], | |||
| '<a href="https://www.phpbb.com/go/anti-spam-ext" target="_blank" style="font-weight: bold;">', '</a>') | |||
There was a problem hiding this comment.
I don't think target="_blank" is valid or has been for the last few years.
There was a problem hiding this comment.
PHPBB3-12961
PHPBB3-12961
|
Website team will need to create redirects for: |
| @@ -298,6 +298,7 @@ | |||
| // Visual Confirmation Settings | |||
| $lang = array_merge($lang, array( | |||
| 'ACP_VC_SETTINGS_EXPLAIN' => 'Here you can select and configure plugins, which are designed to block automated form submissions by spambots. These plugins typically work by challenging the user with a <em>CAPTCHA</em>, a test which is designed to be difficult for computers to solve.', | |||
| 'ACP_VC_EXT_GET_MORE' => 'For additional (and possibly better) anti-spam plugins, visit the <a href="https://www.phpbb.com/go/anti-spam-ext" target="_blank" style="font-weight: bold;">phpBB.com anti-spam extensions database</a>. For more information on preventing spam on your board, visit the <a href="https://www.phpbb.com/go/anti-spam" target="_blank" style="font-weight: bold;">phpBB.com knowledge base</a>.', | |||
There was a problem hiding this comment.
I still don't think target="_blank" is a good idea. We never do that for any .com links
People are clever enough to open links in a new tab nowerdays.
| @@ -298,6 +298,7 @@ | |||
| // Visual Confirmation Settings | |||
| $lang = array_merge($lang, array( | |||
| 'ACP_VC_SETTINGS_EXPLAIN' => 'Here you can select and configure plugins, which are designed to block automated form submissions by spambots. These plugins typically work by challenging the user with a <em>CAPTCHA</em>, a test which is designed to be difficult for computers to solve.', | |||
| 'ACP_VC_EXT_GET_MORE' => 'For additional (and possibly better) anti-spam plugins, visit the <a href="https://www.phpbb.com/go/anti-spam-ext"><strong>phpBB.com anti-spam extensions database</strong></a>. For more information on preventing spam on your board, visit the <a href="https://www.phpbb.com/go/anti-spam"><strong>.com knowledge base</strong></a>.', | |||
There was a problem hiding this comment.
Should be "phpBB.com knowledge base" ?
Don't know how that happened. Weird PHPBB3-12961
|
Don't know how I missed that. Weird. Fixed |
| @@ -298,6 +298,7 @@ | |||
| // Visual Confirmation Settings | |||
| $lang = array_merge($lang, array( | |||
| 'ACP_VC_SETTINGS_EXPLAIN' => 'Here you can select and configure plugins, which are designed to block automated form submissions by spambots. These plugins typically work by challenging the user with a <em>CAPTCHA</em>, a test which is designed to be difficult for computers to solve.', | |||
| 'ACP_VC_EXT_GET_MORE' => 'For additional (and possibly better) anti-spam plugins, visit the <a href="https://www.phpbb.com/go/anti-spam-ext"><strong>phpBB.com anti-spam extensions database</strong></a>. For more information on preventing spam on your board, visit the <a href="https://www.phpbb.com/go/anti-spam"><strong>phpBB.com knowledge base</strong></a>.', | |||
There was a problem hiding this comment.
"phpBB.com anti-spam extensions database" should be "phpBB.com extensions database" ?
There was a problem hiding this comment.
But we want to indicate that we are going to a specific page within the ext database (where all the anti-spam ext are located).
If you think the text of the link shouldn't be that detailed, that's fine with me.
PHPBB3-12961
Can you do that, so we can merge it? |
[ticket/12961] Add link in anti-spam ACP page which links directly to captchas in titania * PayBas/ticket/12961: [ticket/12961] Shorten ext-db link text [ticket/12961] Fix missing phpBB.com [ticket/12961] Remove target="_blank" and switch to <strong> [ticket/12961] Add additional link to the KB [ticket/12961] Move link to language file [ticket/12961] Refactor lang entry [ticket/12961] Change url to anti-spam-ext [ticket/12961] Change url to https://www.phpbb.com/go/anti-spam/ [ticket/12961] Add link in anti-spam ACP page to titania
[ticket/12961] Add link in anti-spam ACP page which links directly to captchas in titania * PayBas/ticket/12961: [ticket/12961] Shorten ext-db link text [ticket/12961] Fix missing phpBB.com [ticket/12961] Remove target="_blank" and switch to <strong> [ticket/12961] Add additional link to the KB [ticket/12961] Move link to language file [ticket/12961] Refactor lang entry [ticket/12961] Change url to anti-spam-ext [ticket/12961] Change url to https://www.phpbb.com/go/anti-spam/ [ticket/12961] Add link in anti-spam ACP page to titania
Since many of the CAPTCHAs that will be shipping with 3.1 are broken, we should add a (big) link, which goes directly to the anti-spam category/tag in the extensions database on phpbb.com.
Additionally, we might want to include a link to the knowledge-base. Or this post: https://www.phpbb.com/community/viewtopic.php?f=46&t=2122696
https://tracker.phpbb.com/browse/PHPBB3-12961