[ticket/12982] JS refactoring

[callumacrae]

https://tracker.phpbb.com/browse/PHPBB3-12982

I'm trying to keep opinions out of this PR (I'm not going to be that guy).

I've converted a load of code to the correct coding standards, and basically fixed most JSHint and IDE errors in the JS.

It also contains a few potential bug fixes such as undeclared variables, and in one case, a typo'd variable name—please don't delay this until 3.2 (that would cause horrible merge conflicts, too).

[callumacrae]

The bulk of this is now finished, the rest will be minor stuff.

[Louis7777]

I thought the following might be related to this PR. See discussion: https://area51.phpbb.com/phpBB/viewtopic.php?f=84&t=45411&start=30#p266263

We use unescape() (when loading jQuery from the local assets) which is a deprecated function. We could replace it with decodeURI().

[callumacrae]

That's not relevant to this PR.

On 21 Aug 2014, at 13:08, Louis7777 notifications@github.com wrote:

I thought the following might be related to this PR. See discussion: https://area51.phpbb.com/phpBB/viewtopic.php?f=84&t=45411&start=30#p266263

We are using unescape() which is a deprecated function. We could replace it with decodeURI().

—
Reply to this email directly or view it on GitHub.

[callumacrae]

!unset WIP

[PayBas]

Did anyone actually test all this yet?

[PayBas]

Been testing this for a while now. Haven't found any obvious problems.

[marc1706]

Any reason why you are still using unbind() here instead of off()?

[marc1706]

PR looks good apart from what I mentioned above.

[callumacrae]

FIXED

[bantu]

@marc1706 Want to merge this then? If not, who else is capable of reviewing this properly? @nickvergessen ?

[marc1706]

Will review this today

[nickvergessen]

This broke the timezone select ...
When you select another time, the timezone list contains all timezones instead of only the ones with the actual time