Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/11909] Remove unused function load_migrations #2909

Merged
merged 1 commit into from Aug 28, 2014

Conversation

n-aleha
Copy link
Contributor

@n-aleha n-aleha commented Aug 26, 2014

Remove unused function load_migrations from \phpbb\db\migrator
Usage of this function was removed in #1267.
The code remained if anyone wanted to use this as per PR message, but hasn't been used up to rc3.

https://tracker.phpbb.com/browse/PHPBB3-11909

PHPBB3-11909

Remove unused function load_migrations from \phpbb\db\migrator

PHPBB3-11909
@marc1706
Copy link
Member

@nickvergessen Is this something we might want to use in the future?

@Nicofuma
Copy link
Member

It remember me that we should add the $check_fulfillable part to database_update, the console command and to the enable/purge step for the extensions...

@nickvergessen
Copy link
Contributor

@marc1706 if we want to use it later, we can still get it back.
At the moment the function seems to be untested and we don't use it, so we can remove it.

marc1706 added a commit to marc1706/phpbb that referenced this pull request Aug 28, 2014
[ticket/11909] Remove unused function load_migrations
@marc1706 marc1706 merged commit bcc1b7a into phpbb:develop-ascraeus Aug 28, 2014
@marc1706
Copy link
Member

@Nicofuma pls create a separate ticket for that as discussed on IRC

@n-aleha n-aleha deleted the ticket/11909 branch August 28, 2014 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants