[ticket/13015] Allow adding multiple notifications per user about the same item

[rxu]

It is impossible to send notification to user about item user already has been
notified. The limitation is hardcoded in notifications manager class.
To allow adding multiple notifications per user about the same item,
move the limitation to the notification type class to be able to set
corresponding notifications behavior on per-type notification basis.

PHPBB3-13015.

[Nicofuma]

Why do you want to notify the user many times for the same item ? You can't edit the previous notification to add the information (like does the quote notification) ?

[rxu]

Imagine that user gets several tens of "thanks" for the same post_id (which is item_id). How would it look like if I add information to previous notification?

[Nicofuma]

IIRC the quote notification display the name until a given limit and then only display the number of quote.
And in this case: do you want to have to mark read tens of notifications? If you have tens of notifications for only one item it could hide the notification for the other things (and if you are like me, if you have 3x time the same notifications you are going to use the button "mark all read"....)

[rxu]

Makes sense. I think I'll try the alternative to update notification with the new time and additional user names thanked for the post. Thanks.
Close the ticket and the PR then?

[EXreaction]

The quote notification is a notification based off of the post id where the user was quoted, so there it makes sense to edit it. I believe new notifications should be created for a given user if that given user has no unread notifications for the item.

Think of the following timeline:
Topic A is created
User Y and user Z subscribe to the topic
Post B is created on topic A (notifications sent to user Y and Z)
User Y visits the post (marks their notification read)
Post C is created on topic A (new notification sent to user Y; previous notification for user Z updated)

Is this how notifications still work for all notification types?

[Nicofuma]

It's exactly what is done by the bookmark notification yes.

[Nicofuma]

For the others notifications I'm not sure that it is possible to try to send 2 notifications for the same item (moderation queue: you are in the queue or not, you can't be twice in the queue; report: you can't report a post already reported; pm; group: you can't send more than one request for the same group...)