Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ticket/13031] Only use mimetype guesser guess if it helps us #2918

Merged
merged 3 commits into from Sep 6, 2014
Merged

[ticket/13031] Only use mimetype guesser guess if it helps us #2918

merged 3 commits into from Sep 6, 2014

Commits on Sep 3, 2014

  1. [ticket/13031] Only use mimetype guesser guess if it helps us 

    If we already have a mimetype and the guesser's guess is the default fallback,
we should keep the already existing mimetype the browser supplied. Otherwise,
platforms that might not support mimetype guessers will cause us to always
have the mimetype set to application/octet-stream on images. This will prevent
users from uploading images.

PHPBB3-13031
    @marc1706
    marc1706 committed Sep 3, 2014
    Copy the full SHA
    7de15bc View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2014

  1. [ticket/13031] Guess with all mimetype guessers and pick best guess 

    PHPBB3-13031
    @marc1706
    marc1706 committed Sep 5, 2014
    Copy the full SHA
    d31ff51 View commit details
    Browse the repository at this point in the history

  2. [ticket/13031] Slightly change behavior of choose_mime_type and add u… 

    …nit tests

The mime type 'application/octet-stream' will still always be overwritten by
proper guesses. However, guesses with guessers that have a higher priority
will now overwrite previous guesses even if the mime types of these guesses
had a slash in them.

PHPBB3-13031
    @marc1706
    marc1706 committed Sep 5, 2014
    Copy the full SHA
    21029e9 View commit details
    Browse the repository at this point in the history