[ticket/13110] Add core event to the page_footer() function #3000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxu
force-pushed
the
ticket/13110
branch
2 times, most recently
from
a4352be
to
eb2aa1f
Compare
Add core event to the page_footer() in includes/functions.php to allow extensions handling overall page output before its displaying. PHPBB3-13110
| * | ||
| * @since 3.1.0-RC5 | ||
| */ | ||
| $vars = array('display_template', 'exit_handler'); |
There was a problem hiding this comment.
Do you really need these variables?
Sounds pretty dangerous to me
There was a problem hiding this comment.
@nickvergessen Yes, in case you would like to override default output behavior, f.e. filter the whole page before displaying etc., roughly
ob_start();
$this->template->display('body');
$content = ob_get_clean();
/* Do something with $content here */
$event['display_template'] = false;
nickvergessen
added a commit
to nickvergessen/phpbb
that referenced
this pull request
Oct 2, 2014
[ticket/13110] Add core event to the page_footer() function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add core event to the page_footer() in includes/functions.php to allow
extensions handling overall page output before its displaying.
PHPBB3-13110.