[ticket/13193] Post count in PMs not a link #3054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPBB3-13193
| @@ -213,6 +213,7 @@ function view_message($id, $mode, $folder_id, $msg_id, $folder, $message_row) | |||
| 'AUTHOR_AVATAR' => (isset($user_info['avatar'])) ? $user_info['avatar'] : '', | |||
| 'AUTHOR_JOINED' => $user->format_date($user_info['user_regdate']), | |||
| 'AUTHOR_POSTS' => (int) $user_info['user_posts'], | |||
| 'U_AUTHOR_POSTS' => ($auth->acl_get('u_search')) ? append_sid("{$phpbb_root_path}search.$phpEx", "author_id=$author_id&sr=posts") : '', | |||
There was a problem hiding this comment.
Missing $config['load_search'] check.
PHPBB3-13193
| @@ -29,7 +29,7 @@ | |||
|
|
|||
| <!-- IF RANK_TITLE or RANK_IMG --><dd class="profile-rank">{RANK_TITLE}<!-- IF RANK_TITLE and RANK_IMG --><br /><!-- ENDIF -->{RANK_IMG}</dd><!-- ENDIF --> | |||
|
|
|||
| <dd class="profile-posts"><strong>{L_POSTS}{L_COLON}</strong> {AUTHOR_POSTS}</dd> | |||
| <dd class="profile-posts"><strong>{L_POSTS}{L_COLON}</strong> <!-- IF U_AUTHOR_POSTS != '' --><a href="{U_AUTHOR_POSTS}"><!-- ENDIF -->{AUTHOR_POSTS}<!-- IF U_AUTHOR_POSTS != '' --></a><!-- ENDIF --></dd> | |||
There was a problem hiding this comment.
<!-- IF U_AUTHOR_POSTS != '' --><a href="{U_AUTHOR_POSTS}">{AUTHOR_POSTS}</a><!-- ELSE -->{AUTHOR_POSTS}<!-- ENDIF --> ?
There was a problem hiding this comment.
I just wanted to keep the same code as used in viewtopic. But I will rewrite it, sure.
PHPBB3-13193
|
Restarted test that timed out. |
bantu
added a commit
to bantu/phpbb
that referenced
this pull request
Oct 25, 2014
[ticket/13193] Post count in PMs not a link * Senky/ticket/13193: [ticket/13193] Make template more readable [ticket/13193] Add load_search config check [ticket/13193] Add link to post count in PMs
| @@ -213,6 +213,7 @@ function view_message($id, $mode, $folder_id, $msg_id, $folder, $message_row) | |||
| 'AUTHOR_AVATAR' => (isset($user_info['avatar'])) ? $user_info['avatar'] : '', | |||
| 'AUTHOR_JOINED' => $user->format_date($user_info['user_regdate']), | |||
| 'AUTHOR_POSTS' => (int) $user_info['user_posts'], | |||
| 'U_AUTHOR_POSTS' => ($auth->acl_get('u_search') && $config['load_search']) ? append_sid("{$phpbb_root_path}search.$phpEx", "author_id=$author_id&sr=posts") : '', | |||
There was a problem hiding this comment.
Please swap the two sides of the &&
See https://github.com/phpbb/phpbb/blob/develop-ascraeus/phpBB/viewtopic.php#L1251
PHPBB3-13193
bantu
added a commit
that referenced
this pull request
Oct 26, 2014
[ticket/13193] Post count in PMs not a link * Senky/ticket/13193: [ticket/13193] Swap ternary condition members [ticket/13193] Make template more readable [ticket/13193] Add load_search config check [ticket/13193] Add link to post count in PMs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPBB3-13193