Added an event to viewtopic.php to modify template vars. #3288
Conversation
| * @var int forum_id Forum ID | ||
| * @var array topic_data Array with topic data | ||
| * @var int topic_id Topic ID | ||
| * @var int total_posts Topic total posts count |
There was a problem hiding this comment.
$total_posts doesn't exist in the vars array below.
|
Please modify your commit message to fit into this format: https://wiki.phpbb.com/Git#Commit_Messages |
|
How do I do this? Should I simpl make this pull request again? regards, Dave |
|
If you use the console, try |
|
No, I use Tortoise... So ist it okay, to just start another pull request. What exactly is wrong with the commit message? I tried to use the mentioned format? What are "consecutive new lines"? Two blank lines? |
|
With TortoiseGit it's even simplier - just choose |
it should be
yes |
|
So... I tried again... |
| 'topic_data', | ||
| 'topic_id', | ||
| ); | ||
| extract($phpbb_dispatcher->trigger_event('core.viewtopic_assign_template_vars', compact($vars))); |
There was a problem hiding this comment.
Should have the same event name as in the docblock above.
|
@DerDave want to try fixing this, or shall we take it over? |
|
Sorry, I've just accepted a new job... I don't have much time right now.... |
|
Replaced by #3368 |
[feature/event](This is my first pull requst, I hope I don't screw this up)
I added an event to viewtopic.php tomodify the template vars as described in the ticket.
PHPBB3-13480