Ticket/13844 Better FAQ language files #3613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I cannot reproduce this one, also the language related changes should have kept full BC |
|
And there isn't any error on travis too... |
PHPBB3-13844
nickvergessen
force-pushed
the
ticket/13844
branch
from
63063c7
to
07231e7
Compare
| $lang = array(); | ||
| } | ||
|
|
||
| $lang = array( |
There was a problem hiding this comment.
Your problem is caused by this. phpBB language files use array_merge($lang, array(.
There was a problem hiding this comment.
Btw, can you tell me your nickname on area51 and phpbb.com?
|
Patch is done aswell |
|
I did not remove the help_* language files. I think we should keep them, and for now do changes in both files, to allow translators to easier copy their fixes over. So we can remove them, after we published the first round of update-diffs for 3.2 |
| * | ||
| */ | ||
|
|
||
| class phpbb_language_test extends phpbb_test_case |
|
Done |
PHPBB3-13844
nickvergessen
force-pushed
the
ticket/13844
branch
from
c0b16d6
to
077051f
Compare
Nicofuma
pushed a commit
that referenced
this pull request
May 29, 2015
Ticket/13844 Better FAQ language files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tracker.phpbb.com/browse/PHPBB3-13844
Todo: