[Ticket/14194] Responsive Quick Links Menu Broken

[hanakin]

ticket: https://tracker.phpbb.com/browse/PHPBB3-14194
PHPBB3-14194

[hanakin]

@VSEphpbb please review when u get a chance

[iMattPro]

2 Issues I see:

1. It is still supposed to say Quick Links next to the hamburger in responsive mode.
2. Legacy "small-icon" object positioning is not handled correctly anymore.

The result of this PR (see the Test item):

The current 3.1.x implementation:

[hanakin]

quicklinks text is removed at responsive

as for small icons not sure on that its going to require some research as it was not really supported just included back in for bc.

[iMattPro]

Well, as for the quick links, as you can see, the Quick Links text is vanishing before it is supposed to. The hamburger should not be left hanging out there all by itself with no label when there is still plenty of room for one...if at all possible ;)

3.1.x:

This PR:

[hanakin]

@VSEphpbb small icon should be fixed, not sure what exactly is want for the Quicklinks I made an adjustment so let me know

[iMattPro]

Still some responsive issues. They may not be related to this PR specifically, but they're what I find when looking so I'm just putting the info up here.

First, I noticed this major blowout in small responsive mode to the forum header bar (it's testable on area51 right now):

Next. The padding around the post button and search bars was better in 3.1 vs 3.2:
3.1.x

3.2.x

[hanakin]

the second one is any easy fix in 3.1 a global margin was applied to the right side which i removed as they were not aligned i will add it back responsively. As for the first one I seen that not sure its related to this PR but its a dousey I have not been able to track down the source of the issue as I believe its steaming from a combination of js buffoonery and responsive css making it extremely difficult to narrow down as JS is not really debuggable for this type of thing which is why its never recommended for handle responsive rendering in this manner.

PS It will take me some time to get to this as I am pretty much out for the next two weeks

[hanakin]

viewforum header fix: #3942

[hanakin]

ready for review

[marc1706]

What are the FAQ, ACP, and MCP links supposed to do on very small screens?
This is what it supposedly looks like on an iPhone 4:

The notifications icon on the next line kinda bugs me.

[hanakin]

is this on area51 or with this merge? it may have gotten messed up when i rebased will look at it when i get a chance...

[marc1706]

That's on up-to-date master with this PR merged.

[Nicofuma]

by the way a51 is now sync with master

[hanakin]

@marc1706 im not seeing what ur seeing

[marc1706]

@hanakin could you rebase this?

[marc1706]

Looks good on an emulated iPhone 4 now, too. Thx