[ticket/14804] Add core event to MCP after merging topics #4472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed $topic_data and defined $to_topic_data in order to avoid ambiguity and to stop overwriting a variable. PHPBB3-14804
rxu
reviewed
Sep 30, 2016
| * @event core.mcp_merge_after | ||
| * @var array all_topic_data The data from all topics involved in the merge | ||
| * @var int to_topic_id The ID of the topic into which the rest are merged | ||
| * @since 3.1.10-RC1 |
There was a problem hiding this comment.
It's too late for 3.1.10-RC1 as it's already out. Should go to 3.1.11-RC1.
rxu
reviewed
Sep 30, 2016
| /** | ||
| * Perform additional actions after merging topics. | ||
| * | ||
| * @event core.mcp_merge_after |
There was a problem hiding this comment.
The name could be more descriptive, like core.mcp_forum_merge_topics_after or something like that.
…nges to 3.1 PHPBB3-14804
…ket/14804 PHPBB3-14804
|
I haven't worked with Travis very much, so I'm not sure if I'm able to manually trigger a build without committing or closing & reopening the PR. |
marc1706
added a commit
to marc1706/phpbb
that referenced
this pull request
Nov 12, 2016
[ticket/14804] Add core event to MCP after merging topics
|
Thanks for the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Tracker ticket (set the ticket ID to your ticket ID):
https://tracker.phpbb.com/browse/PHPBB3-14804
Renamed $topic_data and defined $to_topic_data in order to avoid ambiguity
and to stop overwriting a variable.
PHPBB3-14804