Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/15156] Simplify user online notification #4801

Merged
merged 7 commits into from Apr 27, 2017
Merged

[ticket/15156] Simplify user online notification #4801

merged 7 commits into from Apr 27, 2017

Conversation

hanakin
Copy link
Member

@hanakin hanakin commented Apr 18, 2017

Checklist:

  • Correct branch: master for new features; 3.2.x, 3.1.x for fixes
  • Tests pass
  • Code follows coding guidelines: master / 3.2.x, 3.1.x
  • Commit follows commit message format

PHPBB3-15155
https://tracker.phpbb.com/browse/PHPBB3-15155

@marc1706
Copy link
Member

Can you please add screenshots when e.g. adding something to the style so we can get an idea of what it looks like and also confirm this during testing?

@hanakin
Copy link
Member Author

hanakin commented Apr 18, 2017

yeah plan too but twig errors att?

@hanakin
Copy link
Member Author

hanakin commented Apr 18, 2017

Here are some screens based on inspector editing on area51 for these changes.

screenshot 2017-04-17 20 00 15
screenshot 2017-04-18 07 31 02

@hanakin hanakin closed this Apr 19, 2017
@hanakin hanakin reopened this Apr 19, 2017
@hanakin
Copy link
Member Author

hanakin commented Apr 19, 2017

@marc1706 tests were failing due to the removal of the en folder contents...not sure what this had to do with the acp?

@hanakin
Copy link
Member Author

hanakin commented Apr 20, 2017

ok here are all the screens

screen shot 2017-04-20 at 6 47 00 am
screenshot 2017-04-20 07 01 03 3
screenshot 2017-04-20 07 01 03 2
screenshot 2017-04-20 07 01 03

@meis2m
Copy link

meis2m commented Apr 22, 2017

I think the username and rank must be in center. just like avatar

@hanakin
Copy link
Member Author

hanakin commented Apr 22, 2017

@Persian-phpBB outside the scope of this pr as everything else if left aligned

@marc1706
Copy link
Member

I somehow have the old user online gif still showing up:
image

@hanakin
Copy link
Member Author

hanakin commented Apr 26, 2017

@marc1706 related to the error with acp hopefully this fixes it and allows tests to pass

@vinny
Copy link
Member

vinny commented Apr 26, 2017

@hanakin why keep styles/prosilver/theme/en/stylesheet.css?

@hanakin
Copy link
Member Author

hanakin commented Apr 26, 2017

because for some reason the acp is requireing it and im not sure how to fix the error

marc1706 added a commit to marc1706/phpbb that referenced this pull request Apr 27, 2017
[ticket/15156] Simplify user online notification
@marc1706 marc1706 merged commit 077a3c1 into phpbb:master Apr 27, 2017
@marc1706 marc1706 added this to the 3.3.0-a1 milestone Apr 27, 2017
@hanakin hanakin deleted the ticket/15156 branch May 17, 2017 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants