[ticket/15351] Makes confirm_works in a router context (app.php) #4932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicofuma
force-pushed
the
ticket/15351
branch
2 times, most recently
from
e6343ef
to
5256426
Compare
Elsensee
reviewed
Sep 8, 2017
phpBB/phpbb/path_helper.php
Outdated
| @@ -496,4 +496,17 @@ public function get_valid_page($page, $mod_rewrite = false) | |||
|
|
|||
| return $page; | |||
| } | |||
|
|
|||
| /** | |||
| * Tells if the router is currently in use (if the current page is a route or note) | |||
| // Script name URI (e.g. phpBB/app.php) | ||
| $script_name = $this->symfony_request->getScriptName(); | ||
|
|
||
| return basename($script_name) === 'app.' . $this->php_ext; |
There was a problem hiding this comment.
Does this also work when the .htaccess redirection is in place?
Bugs that are connected to this are nasty.
There was a problem hiding this comment.
yes it works. The script name should always be defined
There was a problem hiding this comment.
Surely it's always defined but does it also always point to the app.php when routing through it but is redirected by .htaccess?
Nicofuma
force-pushed
the
ticket/15351
branch
from
5256426
to
98f7612
Compare
Nicofuma
force-pushed
the
ticket/15351
branch
from
98f7612
to
c368d17
Compare
CHItA
added a commit
that referenced
this pull request
Sep 9, 2017
[ticket/15351] Makes confirm_works in a router context (app.php)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPBB3-15351
Checklist:
Tracker ticket (set the ticket ID to your ticket ID):
https://tracker.phpbb.com/browse/PHPBB3-15351