[ticket/15699] Move files between storages when configuration is changed

[rubencm]

Checklist:

• Correct branch: master for new features; 3.2.x for fixes
• Tests pass
• Code follows coding guidelines: master and 3.2.x
• Commit follows commit message format

Depends on #6533

Tracker ticket (set the ticket ID to your ticket ID):

https://tracker.phpbb.com/browse/PHPBB3-15699

• Remove popup
• Rewrite part of instance adapters
• Show more information on progress, display progress bar
• Use template macros
• Dont allow to update storage when there is a process in progress

[Nicofuma]

Looks good (i only reviewed the last commit) even if I find it a bit sad to have SQL requests like that in many different place. Maybe later we could rework that in order to centralize the SQL requests

[rubencm]

I don't understand what you mean with having the sql query in a diferent place.
About this... it work, but my idea is to do a progress bar and refresh or something to avoid timeouts like in the installer, but don't know much how.

[Nicofuma]

@CHItA @hanakin @marc1706 maybe you can help with the progress bar stuff.
By the way I think we already have something like that for the search index (but it may be a bit old and not reusable).

About the SQL queries forget it.

[rubencm]

Probably i will need to add here in the future
$adapter->set_storage($storage_name);

[Nicofuma]

Still WIP now #4933 has been merged?

[rubencm]

Yes, i think files should be moved with ajax or something in steps, because only with a few files will be timeout

[gooof]

I'am voting for the search index code. It's old and working great.
You should disable the board while moving files.
Get all files (or better all file IDs from database, or even better, from the smallest to the largest ID like the search index creation) and write it as current state to table config_text. Then move file by file and unset it from the config_text json.
https://github.com/phpbb/phpbb/blob/master/phpBB/includes/acp/acp_search.php#L365..L451

[rubencm]

So i save a list with all files and the index as the state?

[gooof]

No sorry, not a good idea. I miss that you add a own storage table. Use it from low to high like the search index creator. You should only save the current ID as state.

[rubencm]

This is done.
I have to check if it works with a large number of files and outside but for a few avatar in local it seems to work.

[Nicofuma]

nice