[ticket/15723] Rewrite gen_rand_string() and gen_rand_string_friendly() #5292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
unique_id returned 16 characters before, i think it should return 32 better. |
Nicofuma
reviewed
Sep 13, 2018
| @@ -88,21 +97,25 @@ function gen_rand_string($num_chars = 8) | |||
| */ | |||
| function gen_rand_string_friendly($num_chars = 8) | |||
| { | |||
| $rand_str = bin2hex(random_bytes($num_chars + 1)); | |||
| $range = array_merge(range('A', 'N'), range('P', 'Z'), range(1, 9)); | |||
There was a problem hiding this comment.
you should add [a-z] too I think
Nicofuma
reviewed
Sep 13, 2018
| @@ -73,8 +73,17 @@ function set_var(&$result, $var, $type, $multibyte = false) | |||
| */ | |||
| function gen_rand_string($num_chars = 8) | |||
| { | |||
| // [a, z] + [0, 9] = 36 | |||
| return substr(strtoupper(base_convert(bin2hex(random_bytes($num_chars + 1)), 16, 36)), 0, $num_chars); | |||
| $range = array_merge(range('A', 'Z'), range(0, 9)); | |||
There was a problem hiding this comment.
you should add [a-z] too I think
There was a problem hiding this comment.
No, is the same characters, in the old version of the function, all characters were converted to uppercase
Nicofuma
approved these changes
Sep 13, 2018
marc1706
added a commit
to marc1706/phpbb
that referenced
this pull request
Sep 17, 2018
[ticket/15723] Rewrite gen_rand_string() and gen_rand_string_friendly()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPBB3-15723
Checklist:
Tracker ticket (set the ticket ID to your ticket ID):
https://tracker.phpbb.com/browse/PHPBB3-15723