Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature/1clickupdate] 1-Click Update #5419

Closed
wants to merge 6 commits into from
Closed

[feature/1clickupdate] 1-Click Update #5419

wants to merge 6 commits into from

Conversation

senky
Copy link
Contributor

@senky senky commented Oct 18, 2018 •
edited

PHPBB3-15851

Checklist:

  • Correct branch: master for new features; 3.2.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.2.x
  • Commit follows commit message format

Tracker ticket (set the ticket ID to your ticket ID):

https://tracker.phpbb.com/browse/PHPBB3-15851

@3D-I
Copy link
Contributor

3D-I commented Oct 19, 2018

Issue created https://tracker.phpbb.com/browse/PHPBB3-15851 FWIW.

@senky senky added the WIP 🚧 label Oct 19, 2018
marc1706
marc1706 reviewed Oct 19, 2018
View reviewed changes
phpBB/composer.lock Outdated
@@ -34,7 +35,7 @@
"MIT"
],
"description": "Convenience wrapper around ini_get()",
"time": "2014-09-15T13:12:35+00:00"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you're not using the currently used composer.phar.

marc1706
marc1706 reviewed Oct 19, 2018
View reviewed changes
phpBB/includes/acp/acp_update.php
$filesystem->remove($tmp_path_dir);

// redirect user to installation script
redirect(append_sid($phpbb_root_path . 'install/app.' . $phpEx));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you'll be redirecting admins to run the database update. Shouldn't it be possible to just run migrations from here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is of course possible, but it's an extra tons of work because we need to be careful with timeouts, permissions, etc, everything correctly handled by the original installer. I'm not sure if it's worth it...

@rubencm rubencm changed the title 1-Click Update [feature/1clickupdate] 1-Click Update Aug 20, 2019
@3D-I
Copy link
Contributor

3D-I commented May 6, 2020

Ok, is anybody there willing to continue this PR that seems to me like abandoned/forgotten?

@ghost ghost mentioned this pull request May 12, 2020
Closed
4 tasks
@rubencm
Copy link
Member

rubencm commented Sep 23, 2023

Close in favor of #6544

@rubencm rubencm closed this Sep 23, 2023
@private-packagist
Copy link

phpBB/composer.lock

⚠️ This update introduces package versions with known vulnerabilities. They are marked with ⚠️

Click to show 120 changes in this composer.lock file

Package changes

Package Operation From To Changes
ocramius/proxy-manager add - 1.0.2 view code
paragonie/random_compat add - v1.4.3 ⚠️ view code
patchwork/utf8 add - v1.3.1 view code
phpseclib/phpseclib add - 2.0.12 ⚠️ view code
symfony/polyfill-php70 add - v1.9.0 view code
zendframework/zend-code add - 2.6.3 view code
zendframework/zend-eventmanager add - 3.2.1 view code
composer/ca-bundle downgrade 1.2.10 1.1.2 diff
composer/composer downgrade 2.1.6 ⚠️ 1.7.2 ⚠️ diff
composer/installers downgrade v1.11.0 v1.5.0 diff
composer/semver downgrade 3.2.5 1.4.2 diff
composer/spdx-licenses downgrade 1.5.5 1.4.0 diff
composer/xdebug-handler downgrade 2.0.2 1.3.0 diff
google/recaptcha downgrade 1.2.4 1.2.1 diff
guzzlehttp/guzzle downgrade 6.5.5 ⚠️ 6.3.3 ⚠️ diff
guzzlehttp/promises downgrade 1.4.1 v1.3.1 diff
guzzlehttp/psr7 downgrade 1.8.2 ⚠️ 1.4.2 ⚠️ diff
justinrainbow/json-schema downgrade 5.2.11 5.2.7 diff
marc1706/fast-image-size downgrade v1.1.6 v1.1.4 diff
psr/container downgrade 1.1.1 1.0.0 diff
psr/log downgrade 1.1.4 1.0.2 diff
s9e/text-formatter downgrade 2.10.0 0.13.1 diff
seld/jsonlint downgrade 1.8.3 1.7.1 diff
seld/phar-utils downgrade 1.1.2 1.0.1 diff
symfony/config downgrade v5.3.4 v3.4.15 diff
symfony/console downgrade v5.3.7 v3.4.15 diff
symfony/debug downgrade v4.4.27 v3.4.15 diff
symfony/dependency-injection downgrade v5.3.7 v3.4.15 ⚠️ diff
symfony/event-dispatcher downgrade v5.3.7 v3.4.15 diff
symfony/filesystem downgrade v5.3.4 v3.4.15 diff
symfony/finder downgrade v5.3.7 v3.4.15 diff
symfony/http-foundation downgrade v5.3.7 v3.4.15 ⚠️ diff
symfony/http-kernel downgrade v5.3.7 ⚠️ v3.4.15 ⚠️ diff
symfony/polyfill-ctype downgrade v1.23.0 v1.9.0 diff
symfony/polyfill-mbstring downgrade v1.23.1 v1.9.0 diff
symfony/process downgrade v5.3.7 v3.4.15 diff
symfony/proxy-manager-bridge downgrade v5.3.4 v3.4.15 ⚠️ diff
symfony/routing downgrade v5.3.7 v3.4.15 diff
symfony/twig-bridge downgrade v5.3.7 v3.4.15 diff
symfony/yaml downgrade v5.3.6 v3.4.15 diff
twig/twig downgrade v3.3.2 ⚠️ v1.35.4 ⚠️ diff
chita/topological_sort remove v3.0.1 - -
composer/metadata-minifier remove 1.0.0 - -
composer/package-versions-deprecated remove 1.11.99.3 - -
doctrine/cache remove 2.1.1 - -
doctrine/dbal remove 3.1.1 ⚠️ - -
doctrine/deprecations remove v0.5.3 - -
doctrine/event-manager remove 1.1.1 - -
friendsofphp/proxy-manager-lts remove v1.0.5 - -
laminas/laminas-code remove 3.4.1 - -
laminas/laminas-eventmanager remove 3.3.1 - -
laminas/laminas-zendframework-bridge remove 1.4.0 - -
psr/event-dispatcher remove 1.0.0 - -
ralouphie/getallheaders remove 3.0.3 - -
react/promise remove v2.8.0 - -
s9e/regexp-builder remove 1.4.5 - -
s9e/sweetdom remove 2.0.0 - -
symfony/deprecation-contracts remove v2.4.0 - -
symfony/error-handler remove v5.3.7 - -
symfony/event-dispatcher-contracts remove v2.4.0 - -
symfony/http-client-contracts remove v2.4.0 - -
symfony/mime remove v5.3.7 - -
symfony/polyfill-intl-grapheme remove v1.23.1 - -
symfony/polyfill-intl-idn remove v1.23.0 - -
symfony/polyfill-intl-normalizer remove v1.23.0 - -
symfony/polyfill-php72 remove v1.23.0 - -
symfony/polyfill-php73 remove v1.23.0 - -
symfony/polyfill-php80 remove v1.23.1 - -
symfony/polyfill-php81 remove v1.23.0 - -
symfony/service-contracts remove v2.4.0 - -
symfony/string remove v5.3.7 - -
symfony/translation-contracts remove v2.4.0 - -
symfony/var-dumper remove v5.3.7 - -

Dev Package changes

Package Operation From To Changes
facebook/webdriver add - 1.6.0 view code
phpunit/dbunit add - 2.0.3 view code
phpunit/php-token-stream add - 1.4.12 view code
phpunit/phpunit-mock-objects add - 3.4.4 view code
doctrine/instantiator downgrade 1.4.0 1.0.5 diff
fabpot/goutte downgrade v3.3.1 v3.2.3 diff
laravel/homestead downgrade v10.17.0 v7.17.0 diff
myclabs/deep-copy downgrade 1.10.2 1.7.0 diff
phing/phing downgrade 2.17.0 2.4.14 diff
phpdocumentor/reflection-common downgrade 2.2.0 1.0.1 diff
phpdocumentor/reflection-docblock downgrade 5.2.2 3.3.2 diff
phpdocumentor/type-resolver downgrade 1.4.0 0.4.0 diff
phpspec/prophecy downgrade 1.13.0 1.8.0 diff
phpunit/php-code-coverage downgrade 9.2.6 4.0.8 diff
phpunit/php-file-iterator downgrade 3.0.5 1.4.5 diff
phpunit/php-text-template downgrade 2.0.4 1.2.1 diff
phpunit/php-timer downgrade 5.0.3 1.0.9 diff
phpunit/phpunit downgrade 9.5.9 5.7.27 diff
sebastian/code-unit-reverse-lookup downgrade 2.0.3 1.0.1 diff
sebastian/comparator downgrade 4.0.6 1.2.4 diff
sebastian/diff downgrade 4.0.4 1.4.3 diff
sebastian/environment downgrade 5.1.3 2.0.0 diff
sebastian/exporter downgrade 4.0.3 2.0.0 diff
sebastian/global-state downgrade 5.0.3 1.1.1 diff
sebastian/object-enumerator downgrade 4.0.4 2.0.1 diff
sebastian/recursion-context downgrade 4.0.4 2.0.0 diff
sebastian/resource-operations downgrade 3.0.3 1.0.0 diff
sebastian/version downgrade 3.0.2 2.0.1 diff
squizlabs/php_codesniffer downgrade 3.6.0 2.9.1 diff
symfony/browser-kit downgrade v5.3.4 v3.4.15 diff
symfony/css-selector downgrade v5.3.4 v3.4.15 diff
symfony/dom-crawler downgrade v5.3.7 v3.4.15 diff
webmozart/assert downgrade 1.10.0 1.3.0 diff
misantron/dbunit remove 5.1.0 - -
nikic/php-parser remove v4.12.0 - -
phar-io/manifest remove 2.0.3 - -
phar-io/version remove 3.1.0 - -
phpunit/php-invoker remove 3.1.1 - -
sebastian/cli-parser remove 1.0.1 - -
sebastian/code-unit remove 1.0.8 - -
sebastian/complexity remove 2.0.2 - -
sebastian/lines-of-code remove 1.0.3 - -
sebastian/object-reflector remove 2.0.4 - -
sebastian/type remove 2.3.4 - -
theseer/tokenizer remove 1.2.1 - -

Important Metadata Changes

Package Version Metadata From To
webmozart/assert 1.3.0 dist url https://api.github.com/repos/webmozarts/assert/zipball/6964c76c7804814a842473e0c8fd15bab0f18e25 https://api.github.com/repos/webmozart/assert/zipball/0df1908962e7a3071564e857d86874dad1ef204a
webmozart/assert 1.3.0 source url https://github.com/webmozarts/assert.git https://github.com/webmozart/assert.git

Settings · Docs · Powered by Private Packagist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc1706 marc1706 marc1706 left review comments

Assignees
No one assigned
Labels
WIP 🚧
Projects
None yet
Milestone
No milestone
4 participants
@senky @3D-I @rubencm @marc1706