[ticket/16076] addFileFilter to check max file size per mime type

[ghost]

PHPBB3-16076

Checklist:

• Correct branch: master for new features; 3.3.x & 3.2.x for fixes
• Tests pass
• Code follows coding guidelines: master, 3.3.x and 3.2.x
• Commit follows commit message format

Tracker ticket (set the ticket ID to your ticket ID):

https://tracker.phpbb.com/browse/PHPBB3-16076

[EA117]

What will be the intended relationship between the per-Attachment Extension Group "Maximum file size" and the main ACP Attachment Settings "Maximum File Size"?

If the per-group value is set to zero, does this mean "I want to be limited by whatever the main ACP Attachment Settings maximum file size is set to"? Or is setting a per-group value to zero an assertion that "even though other downloads may be limited, this particular Attachment Extension Group needs to be unlimited"?

The proposed change hasn't stopped passing "max_file_size: '{FILESIZE}b'" in the plupload config, so I'm just trying to picture what the actual effect, interaction and intention will be.

[ghost]

All files are limited to the general "maximum file size".
Per group you can lower the maximum file size.

The general one, is the 'overall' rule for attachment filesize, each and every attachment has to adhere to. Otherwise you will start working 'exceptions' and then you lose track rather quickly.

This also simply means, setting a group's maximum filesize to 0, that a group does not specific maximum filesize, other than the overall one.

The provides a linear way of thinking / managing:
"overall" is the absolute limit and you can lower them per group.