Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/16084] Remove redundant backup radio button #5666

Merged
merged 1 commit into from Sep 1, 2019

Conversation

@mrgoldy
Copy link
Contributor

commented Aug 25, 2019

PHPBB3-16084

Checklist:

  • Correct branch: master for new features; 3.3.x & 3.2.x for fixes
  • Tests pass
  • Code follows coding guidelines: master, 3.3.x and 3.2.x
  • Commit follows commit message format

Tracker ticket (set the ticket ID to your ticket ID):

https://tracker.phpbb.com/browse/PHPBB3-16084

PHPBB3-16084
@mrgoldy mrgoldy closed this Aug 25, 2019
@mrgoldy mrgoldy reopened this Aug 25, 2019
@mrgoldy

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

Just to clarify, the ticket suggested

Better if just text explaining that the backup is stored in /stores folder.

But this is already present in the module description:

Here you can backup all your phpBB related data. The resulting archive will be stored in your store/ folder. Depending on your server configuration you may be able to compress the file in a number of formats.

@marc1706 marc1706 changed the base branch from master to 3.2.x Sep 1, 2019
@marc1706 marc1706 added this to the 3.2.9 milestone Sep 1, 2019
@marc1706 marc1706 added the 3.2 (Rhea) label Sep 1, 2019
marc1706 added a commit to marc1706/phpbb that referenced this pull request Sep 1, 2019
[ticket/16084] Remove redundant backup radio button
@marc1706 marc1706 merged commit 88ec8cd into phpbb:3.2.x Sep 1, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mrgoldy mrgoldy deleted the mrgoldy:ticket/16084 branch Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.