[ticket/15572] Fix W3C validation error for quote BBCode

[AlfredoRamos]

Checklist:

• Correct branch: master for new features; 3.3.x & 3.2.x for fixes
• Tests pass
• Code follows coding guidelines: master, 3.3.x and 3.2.x
• Commit follows commit message format

Tracker ticket:

https://tracker.phpbb.com/browse/PHPBB3-15572

[3D-I]

Does it also takes into consideration the quotes in PMs? @msg_url

[AlfredoRamos]

@3D-I I thought about it but I'm not sure if I should also check for the @msg_url (cite attribute) since that URL links to a private content, which is not publicly accessible.

[Dark1z]

Well !!! in PM , there is no way for a W3C validator to do any validation.
So this PR is perfect for @post_url.

Also nice that you changed div to span 😄

Best regards 👍

[rxu]

After this change, what will happen with BBCode in old posts (already saved in database)? Will they require reparsing?

[AlfredoRamos]

@rxu no, it only requires the user to clear the cache so TextFormatter (trough phpbb/textformatter/s9e/factory.php) can read that file to setup those BBCodes again.

[rxu]

What I meant is whether quote BBCode in 'old' posts will be broken. So if they won't, that's good.

[AlfredoRamos]

@rxu in my tests I didn't had problems with previously posted messages.

Should I keep the blockquote cite > div CSS selector just to be sure? Because the worst thing that can happen is that date won't be located at the right of the quoted message.

[rxu]

Tested locally: posted a message and then applied the changes from the PR.
Before:

After:

[Dark1z]

After:

I think you forgot the CSS part.
Here : https://github.com/phpbb/phpbb/pull/5932/files#diff-640d4c568fbd9176eefbdfbd5782e31aR487
& then purge the cache.

Best regards 👍

[rxu]

I did apply both of HTML/CSS parts while recompiling outdated templates setting is on, but purging cache made it right, my bad :)

[Dark1z]

I did apply both of HTML/CSS parts while recompiling outdated templates setting is on, but purging cache made it right, my bad :)

Ahh! Nice 😍 .

Best regards 👍

[ghost]

@3D-I I thought about it but I'm not sure if I should also check for the @msg_url (cite attribute) since that URL links to a private content, which is not publicly accessible.

Could you expand a bit please, @AlfredoRamos?
Cause just because it's not accessible for bots, shouldn't mean it can have invalid markup.

[AlfredoRamos]

@mrgoldy The missing cite attribute (<blockquote cite="...">) doesn't make the markup invalid.

I said that I didn't include that attribute on private messages because I didn't see the point for it.

[marc1706]

Agreed, the cite attribute will definitely help the search engines there. :)