Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ticket/16705] Fix check_disk_space function - PHP 8 #6141

Merged
merged 4 commits into from Mar 5, 2021
Merged

[ticket/16705] Fix check_disk_space function - PHP 8 #6141

merged 4 commits into from Mar 5, 2021

Conversation

3D-I
Copy link
Contributor

@3D-I 3D-I commented Feb 9, 2021 •
edited

PHPBB3-16705

Checklist:

  • Correct branch: master for new features; 3.3.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.3.x
  • Commit follows commit message format

https://tracker.phpbb.com/browse/PHPBB3-16705

@3D-I
Copy link
Contributor Author

3D-I commented Feb 9, 2021 •
edited

@rxu Could you please have a look at the test file?

@3D-I 3D-I marked this pull request as draft February 9, 2021 23:00
@rubencm
Copy link
Member

rubencm commented Feb 10, 2021

This has to be fixed in master too

@3D-I
Copy link
Contributor Author

3D-I commented Feb 10, 2021

This has to be fixed in master too

Will the PR against 3.3.x be merged also in master?

@3D-I 3D-I marked this pull request as ready for review February 16, 2021 23:35
@3D-I
Copy link
Contributor Author

3D-I commented Feb 16, 2021

Not a test expert here. I will leave that to you in case.

@3D-I 3D-I requested a review from marc1706 February 26, 2021 11:44
@3D-I 3D-I changed the title [ticket/16705] Fix check_disk_space function [ticket/16705] Fix check_disk_space function - PHP8 Mar 3, 2021
@3D-I 3D-I changed the title [ticket/16705] Fix check_disk_space function - PHP8 [ticket/16705] Fix check_disk_space function - PHP 8 Mar 3, 2021
3D-I added 2 commits March 5, 2021 08:00
[ticket/16705] Fix check_disk_space function
2ea22ee 
Silent potential warnings

PHPBB3-16705
[ticket/16705] Fix check_disk_space function
5d18ad6 
Allow upload even if the check fails

PHPBB3-16705
@marc1706 marc1706 added this to the 3.3.4 milestone Mar 5, 2021
@3D-I 3D-I closed this Mar 5, 2021
@3D-I 3D-I reopened this Mar 5, 2021
@marc1706 marc1706 merged commit b978fd9 into phpbb:3.3.x Mar 5, 2021
@3D-I 3D-I deleted the ticket/16705 branch March 6, 2021 00:07
@phpbb phpbb locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DavidIQ DavidIQ DavidIQ left review comments

@Stokestack Stokestack Stokestack left review comments

@marc1706 marc1706 marc1706 approved these changes

Assignees
No one assigned
Labels
3.3 (Proteus) 🌑
Projects
None yet
Milestone
3.3.4
5 participants
@3D-I @rubencm @DavidIQ @Stokestack @marc1706