Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ticket/16823] Make datetime class correctly handle edge cases #6252

Merged
merged 2 commits into from Jul 31, 2021
Merged

[ticket/16823] Make datetime class correctly handle edge cases #6252

merged 2 commits into from Jul 31, 2021

Conversation

rxu
Copy link
Contributor

@rxu rxu commented Jul 20, 2021 •
edited

Checklist:

  • Correct branch: master for new features; 3.3.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.3.x
  • Commit follows commit message format

PHPBB3-16823.

@rxu
Copy link
Contributor Author

rxu commented Jul 20, 2021 •
edited

I'm not sure what to do with the 2nd part of the issue regarding handling +5 / +59 seconds ahead: either drop this behavior or leave it as is.

EDIT: I guess I'll leave it as is for now.

@CHItA CHItA added this to the 3.3.5 milestone Jul 31, 2021
@CHItA CHItA merged commit 90fccff into phpbb:3.3.x Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CHItA CHItA CHItA approved these changes

Assignees
No one assigned
Labels
3.3 (Proteus) 🌑
Projects
None yet
Milestone
3.3.5
3 participants
@rxu @CHItA @marc1706