Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ticket/16888] List allowed attachment types using accept attribute #6306

Merged
merged 12 commits into from Oct 17, 2021
Merged

[ticket/16888] List allowed attachment types using accept attribute #6306

merged 12 commits into from Oct 17, 2021

Conversation

3D-I
Copy link
Contributor

@3D-I 3D-I commented Oct 10, 2021 •
edited

PHPBB3-16888

Checklist:

  • Correct branch: master for new features; 3.3.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.3.x
  • Commit follows commit message format

https://tracker.phpbb.com/browse/PHPBB3-16888

@3D-I 3D-I marked this pull request as draft October 10, 2021 09:47
@3D-I
[ticket/16888] Add the list of allowed files in the attachment tab
9ca7043 
Make sure we are checking both PMs and topics

PHPBB3-16888
@3D-I 3D-I marked this pull request as ready for review October 10, 2021 11:28
@3D-I
[ticket/16888] Add the list of allowed files in the attachment tab
52c931a 
Request mixed content using shorthand Ternary

PHPBB3-16888
rxu
rxu reviewed Oct 10, 2021
View reviewed changes
phpBB/language/en/posting.php Outdated Show resolved Hide resolved
@marc1706
Copy link
Member

Honestly, I don't expect anyone to read this list of extensions (in addition to it looking quite ugly 😆 ). Why don't we try using the accept attribute instead? https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/file#accept

@3D-I
Copy link
Contributor Author

3D-I commented Oct 10, 2021 •
edited

@marc1706 pls have a look at the code changes (accept attribute).

@3D-I 3D-I requested a review from marc1706 October 11, 2021 00:51
@3D-I 3D-I changed the title [ticket/16888] Add the list of allowed files in the attachment tab [ticket/16888] List allowed attachment types using accept attribute Oct 11, 2021
@3D-I 3D-I closed this Oct 11, 2021
@3D-I 3D-I reopened this Oct 11, 2021
@3D-I
Copy link
Contributor Author

3D-I commented Oct 11, 2021

Topic PM
image image

@rxu
Copy link
Contributor

rxu commented Oct 11, 2021

Will this work with Plupload's drag'n'drop? I was experimenting with extensions in regard of attachments several times and it's a PITA to apply any even simple things to Plupload stuff, I just suspect the patch won't affect it at all.

@3D-I
Copy link
Contributor Author

3D-I commented Oct 11, 2021 •
edited

Will this work with Plupload's drag'n'drop?

I do not think so, I told @marc1706 about that (I edited my previous message about that, sorry)

@3D-I
[ticket/16888] Add the list of allowed files in the attachment tab
7355ee6 
Add core.modify_default_attachments_template_vars

PHPBB3-16888
@marc1706
Copy link
Member

It should already work for plupload based on the filters set for it, so even before this was done for just the "plain" upload button.

@marc1706 marc1706 added this to the 3.3.6 milestone Oct 17, 2021
@marc1706 marc1706 merged commit da7c9f6 into phpbb:3.3.x Oct 17, 2021
@3D-I 3D-I deleted the ticket/16888 branch October 17, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxu rxu rxu left review comments

@marc1706 marc1706 marc1706 approved these changes

Assignees
No one assigned
Labels
3.3 (Proteus) 🌑
Projects
None yet
Milestone
3.3.6
3 participants
@3D-I @marc1706 @rxu