[ticket/15028] Rename automatic to advanced update #6368
Conversation
Also made it clear that it's only for expert users. PHPBB3-15028
phpBB/docs/INSTALL.html
Outdated
| <p>This update method is only recommended for installations with modifications to core phpBB files. This package detects changed files automatically and merges in changes if needed.</p> | ||
| <p>This update method should only be used for installations with modifications to core phpBB files. If you simply use Extensions or custom Styles and have not modified core files, please use the Full Package update.</p> | ||
|
|
||
| <p>This package detects changed files and merges in changes if needed. Since this type of update has a potential to cause issues while upgrading, it is not recommended being used for updates and/or upgrades.</p> |
There was a problem hiding this comment.
Since this type of update has a potential to cause issues while upgrading, it is not recommended being used for updates and/or upgrades.
This seems a bit convoluted to me.
There was a problem hiding this comment.
I was about to say the same
"it is not recommended being used for updates and/or upgrades." then what is it to be used for?
There was a problem hiding this comment.
It is not recommended to be used, instead the full package update should be used.
There was a problem hiding this comment.
I would suggest to re-phrase what I quoted above, in the whole.
There was a problem hiding this comment.
Besides, who is going to explain it to all those who support phpBB in the support forums? Many of them are still tied to old versions of phpBB. It's just confusing, it's common knowledge that it shouldn't be used, it's been explained and all ad nauseam. I don't find it important.
There was a problem hiding this comment.
Since this type of update is only for expert users/coders, it is not recommended being used on production sites
There was a problem hiding this comment.
I do agree about wording, but let's be honest, those people who shouldn't use so called automatic update don't read descriptions anyway. Proof for that is support forum. Issue will be solved, when this update method will be removed for good.
There was a problem hiding this comment.
^^ I do agree. This PR makes no sense at this very point in time. Too late.
I would avoid this and remove that method in the next 3.3.7.
There was a problem hiding this comment.
I have now rephrased this sentence a bit.
There was a problem hiding this comment.
I personally have thought a lot about this PR. I confirm that it does not make sense in my opinion and I would avoid it. In the end it doesn't matter how we want to rephrase the description, regardless of the fact that it was convoluted from the very beginning. So I don't feel like approving the changes. I have already expressed my opinion on this in previous posts setting out the facts. Obviously I have no power to prevent this merge but I hope my opinion will be valued, whatever the outcome.
…pdate PHPBB3-15028
…vanced PHPBB3-15028
Also made it clear that it's only for expert users.
PHPBB3-15028
Checklist:
Tracker ticket (set the ticket ID to your ticket ID):
https://tracker.phpbb.com/browse/PHPBB3-15028