Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/16973] Use actual role ids for comparison of orphaned roles #6373

Closed
wants to merge 1 commit into from

Conversation

marc1706
Copy link
Member

@marc1706 marc1706 commented Mar 17, 2022

PHPBB3-16973

Checklist:

  • Correct branch: master for new features; 3.3.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.3.x
  • Commit follows commit message format

Tracker ticket (set the ticket ID to your ticket ID):

https://tracker.phpbb.com/browse/PHPBB3-16973

@marc1706 marc1706 added this to the 3.3.7 milestone Mar 17, 2022
@3D-I
Copy link
Contributor

3D-I commented Mar 17, 2022

What about the boards that are bound to get broken with 3.3.6?

@rxu
Copy link
Contributor

rxu commented Mar 17, 2022

OMG, I guess I've broke something again.

@3D-I
Copy link
Contributor

3D-I commented Mar 17, 2022

Time to release a PL version.

@marc1706
Copy link
Member Author

Rebased onto prep-release-3.3.6

marc1706 added a commit to marc1706/phpbb that referenced this pull request Mar 17, 2022
[ticket/16973] Use actual role ids for comparison of orphaned roles
@marc1706
Copy link
Member Author

Merged via marc1706@34f27a1

@marc1706 marc1706 closed this Mar 17, 2022
@marc1706 marc1706 deleted the ticket/16973 branch March 17, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants