[ticket/16913] Add Search Index Progress Bar with Stats [3.3.x]

[Dark1z]

PR for phpbb:master is at #6441 .

---

ScreenShot:
.
1st run (On Submit) :

.
2nd & consecutive run (On each Refresh) :

.
Continue to run (In-case the Indexing was Interrupted) :

.
Changes :

• Update SQL for count of posts
• Update search index test
• Removed "Pop-up Progress Bar".
• For first run display the "Success Message".
• Display the Info from "Pop-up Progress Bar" to "Success Message".
• Only display "Redirect" & "Rate" of post refreshed "Success Message".
• Minor Language Fix.
• Use ORDER BY post_id ASC for progress stats.
• Removed HTML from Lang String.
• Moved HTML to PHP file.
• Increased the size of Progress-Bar by 2x.

Checklist:

• Correct branch: master for new features; 3.3.x for fixes
• Tests pass
• Code follows coding guidelines: master and 3.3.x
• Commit follows commit message format

Tracker ticket (set the ticket ID to your ticket ID):

https://tracker.phpbb.com/browse/PHPBB3-16913

[marc1706]

I have played around a bit with your pull request. Generally we're trying to move away from using HTML in PHP files which is also why I started adjusting this a bit: DaRk1V0iD/phpbb@ticket/16913_3.3.x...marc1706:phpbb:ticket/16913_3.3.x

After my changes, the progress bar looks as follows:

IMHO the alignment of the progress bar when being asked about continuing the indexing also fits in better now. If you want I can also add my commit on top of your changes here.

[Dark1z]

I have played around a bit with your pull request. Generally we're trying to move away from using HTML in PHP files which is also why I started adjusting this a bit: DaRk1V0iD/phpbb@ticket/16913_3.3.x...marc1706:phpbb:ticket/16913_3.3.x
...
IMHO the alignment of the progress bar when being asked about continuing the indexing also fits in better now. If you want I can also add my commit on top of your changes here.

Yes! please do any required changes which you think is most appropriate.

My aim was that the end user is well informed about the current (to be more precise last) completed status of search index,
So that users can estimate by assumption or inference of how long it might take to finish the search index.

Best regards 👍

[marc1706]

Btw, if you enable to allow edits to this PR, I could directly add my changes (should be on the right side below the participants info):

If you allow the same for the master version of this PR I can also update that.

[Dark1z]

Btw, if you enable to allow edits to this PR, I could directly add my changes (should be on the right side below the participants info): If you allow the same for the master version of this PR I can also update that.

I can not see that option:

Due to this issue https://github.com/orgs/community/discussions/5634

Instead can I give you maintainer role in that repository ?

---

Edit:
Or should I take the pull from here: DaRk1V0iD/phpbb@ticket/16913_3.3.x...marc1706:phpbb:ticket/16913_3.3.x ?

---

Best regards 👍

[marc1706]

Yes, you should be able to pull from my branch via fast forward and then push to yours.

[Dark1z]

Yes, you should be able to pull from my branch via fast forward and then push to yours.

Done.

[marc1706]

And merged. Changes will be included in 3.3.11. Thanks for your contribution. 🚀