[ticket/17036] Fix failure to strip Authorization header on HTTP downgrade #6414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc1706
changed the title
|
Hi @imhunterand and thanks for your PR. I've taken the liberty to adjust your commit message to our commit message format and created a fitting ticket in our tracker for you. 😎 |
|
The composer.lock diff comment has been updated to reflect new changes in this PR. |
|
The composer.lock diff comment has been updated to reflect new changes in this PR. |
|
Closed and reopened to trigger a fresh build with 3.3.x as base. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the bugs: 🐛
The software performs an authorization check when an actor attempts to access a resource or perform an action, but it does not correctly perform the check. This allows attackers to bypass intended access restrictions.
Guzzle is an open source PHP HTTP client. In affected versions
Authorizationheaders on requests are sensitive information. On making a request using thehttpsscheme to a server which responds with a redirect to a URI with thehttpscheme, we should not forward theAuthorizationheader on. This is much the same as to how we don't forward on the header if the host changes. Prior to this fix,httpstohttpdowngrades did not result in theAuthorizationheader being removed, only changes to the host. Affected Guzzle 7 users should upgrade to Guzzle 7.4.4 as soon as possible. Affected users using any earlier series of Guzzle should upgrade to Guzzle 6.5.7 or 7.4.4. Users unable to upgrade may consider an alternative approach which would be to use their own redirect middleware. Alternately users may simply disable redirects all together if redirects are not expected or required.Fix failure to strip Authorization header on HTTP downgrade
CVE-2022-31043
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:NGHSA-w248-ffj2-4v5q
Checklist:
Tracker ticket (set the ticket ID to your ticket ID):
https://tracker.phpbb.com/browse/PHPBB3-17036