Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ticket/16955] Improve code and docblocks to resolve psalm results #6439

Merged
merged 42 commits into from Jan 3, 2023
Merged

[ticket/16955] Improve code and docblocks to resolve psalm results #6439

merged 42 commits into from Jan 3, 2023

Conversation

marc1706
Copy link
Member

@marc1706 marc1706 commented Dec 27, 2022 •
edited

Checklist:

  • Correct branch: master for new features; 3.3.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.3.x
  • Commit follows commit message format

Tracker ticket (set the ticket ID to your ticket ID):

https://tracker.phpbb.com/browse/PHPBB3-16937
https://tracker.phpbb.com/browse/PHPBB3-16955

@marc1706 marc1706 added this to the 4.0.0-a1 milestone Dec 27, 2022
@private-packagist
Copy link

phpBB/composer.lock

Dev Package changes

Package Operation From To Changes
psalm/plugin-symfony upgrade v3.1.9 v3.1.10 diff
vimeo/psalm upgrade 4.29.0 4.30.0 diff

Settings · Docs · Powered by Private Packagist

@marc1706 marc1706 removed the WIP 🚧 label Dec 27, 2022
@marc1706
[ticket/16955] Use common code for path iterator generation
9a546c5 
PHPBB3-16955
@marc1706
[ticket/16955] Update psalm and improve config & bootstrap
160510d 
PHPBB3-16955
@marc1706
[ticket/16955] Correct docblocks in diff engine
ea07e49 
PHPBB3-16955
@marc1706
[ticket/16955] Improve minor docblock quirks
cd02624 
PHPBB3-16955
@marc1706
[ticket/16955] Resolve psalm issues in di files
c4d3e1a 
PHPBB3-16955
@marc1706
[ticket/16955] Clean up group related classes for psalm
d9c179f 
PHPBB3-16955
@marc1706
[ticket/16955] Clean up installer classes for psalm
40e8a73 
PHPBB3-16955
@marc1706
[ticket/16955] Wrap RecursiveDirectoryIteratorr calls for dot prefix …
733f4e2 
…filter

PHPBB3-16955
@marc1706
[ticket/16955] Clean up variable names and docblocks in notifications
96911b7 
PHPBB3-16955
@marc1706
[ticket/16955] Fix another batch of docblocks
5b23dcd 
PHPBB3-16955
@marc1706
[ticket/16955] Clean up request classes
056f786 
PHPBB3-16955
@marc1706
[ticket/16955] Clean up rrouter and fulltext_sphinx
b90f384 
PHPBB3-16955
@marc1706
[ticket/16955] Improve consistency of user and session class
077ceba 
PHPBB3-16955
@marc1706
[ticket/16955] Clean up storage and template classes
60c165c 
PHPBB3-16955
@marc1706
[ticket/16955] Clean up textformatter and textreparser
6ad0b53 
PHPBB3-16955
@marc1706
[ticket/16955] Clean up reset_password and user_loader
1c02b1a 
PHPBB3-16955
@marc1706
[ticket/16955] Update tests to support small changes to docblocks/types
d3d53cd 
PHPBB3-16955
@marc1706
[ticket/16955] Clean up filesystem and files classes
7f61f8b 
PHPBB3-16955
@marc1706
[ticket/16955] Clean up feed classes
e1a3b6b 
PHPBB3-16955
@marc1706
[ticket/16955] Clean up debug, event, and extension classes
de9019d 
PHPBB3-16955
@marc1706
[ticket/16955] Add stubs for oci8, pgsql, and sqlite3
3bc100c 
PHPBB3-16955
@marc1706
[ticket/16955] Clean up code in db classes
9480230 
PHPBB3-16955
@marc1706
[ticket/16955] Remove shell option as this has been removed in Symfon…
a8b8783 
…y 3.0

PHPBB3-16955
@marc1706
[ticket/16955] Clean up cron and console classes
b855b8a 
PHPBB3-16955
@rubencm rubencm force-pushed the ticket/16955 branch 2 times, most recently from b2873c0 to c4f5b6f Compare December 31, 2022 14:35
@rubencm rubencm force-pushed the ticket/16955 branch 4 times, most recently from 5502c46 to 1c472c5 Compare January 2, 2023 00:59
@marc1706 marc1706 merged commit c90d84a into phpbb:master Jan 3, 2023
@marc1706 marc1706 deleted the ticket/16955 branch January 3, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubencm rubencm rubencm approved these changes

Assignees
No one assigned
Labels
4.0 (Triton) 🔮
Projects
None yet
Milestone
4.0.0-a1
2 participants
@marc1706 @rubencm