Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ticket/17127] Do not purge guest sessions when resetting password #6477

Merged
merged 2 commits into from Apr 11, 2023
Merged

[ticket/17127] Do not purge guest sessions when resetting password #6477

merged 2 commits into from Apr 11, 2023

Conversation

rxu
Copy link
Contributor

@rxu rxu commented Apr 7, 2023 •
edited

Checklist:

  • Correct branch: master for new features; 3.3.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.3.x
  • Commit follows commit message format

PHPBB3-17127.

rxu and others added 2 commits April 7, 2023 18:37
@rxu
[ticket/17127] Do not purge guest sessions when resetting password
98f6a1a 
PHPBB3-17127
@marc1706
[ticket/17127] Remove redundant check for changed password
c272144 
user_password will have been updated if u_chgpasswd is yes and new password
has been set, no need to check password against old hash again.

PHPBB3-17127
@marc1706
Copy link
Member

Good catch. I've reviewed the other places and also added a small change to remove redundant logic.

@marc1706 marc1706 added this to the 3.3.11 milestone Apr 10, 2023
@marc1706 marc1706 merged commit 640a222 into phpbb:3.3.x Apr 11, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3.3 (Proteus) 🌑
Projects
None yet
Milestone
3.3.11
2 participants
@rxu @marc1706