[ticket/17097] Fix PHP 8.2 deprecation warnings

[m-ober]

Checklist:

• Correct branch: master for new features; 3.3.x for fixes
• Tests pass
• Code follows coding guidelines: master and 3.3.x
• Commit follows commit message format

Tracker ticket (set the ticket ID to your ticket ID):

https://tracker.phpbb.com/browse/PHPBB3-17097

[m-ober]

Maybe it would be better to add role_cache as property to the auth class, but I don't know if this was left out intentional.

In case of phpbb_root_path it looks like it was simply forgotten.

[m-ober]

We could also replace the ReturnTypeWillChange attributes with the actual return type, except for offsetGet, which has a mixed return type that is only supported by PHP >=8.0.

[m-ober]

As this question came up in chat, Attributes are backwards compatible as long as they are on a separate line. Then, they are just parsed as comments by PHP <8.0.

[marc1706]

Maybe it would be better to add role_cache as property to the auth class, but I don't know if this was left out intentional.

In case of phpbb_root_path it looks like it was simply forgotten.

It actually does not need to be a class property as it's never used as such. In master, it was changed to no longer use this:
774c609#diff-d3edffaad6045eb7577d57cbb613c8903eb4d239c9f41aeaabfd1218ebdc596c

[marc1706]

Thanks for the pull request. Rest of the changes look fine. Do you want to apply the above changes? Otherwise it's also fine with me to skip them.

[marc1706]

Closed and reopened the PR to trigger builds. ;)

[m-ober]

@marc1706 Thanks for the review! I have cherry-picked the changes from master (for the changes regarding the $role_cache variable only). Also, I have added the #[\ReturnTypeWillChange] attribute to the same methods in the config class. I never got a deprecation notice from this class, but as it is also implementing the ArrayAccess interface, it could trigger the same notices.

[m-ober]

Any idea why the "Check commit message" step is failing? The error message is not very helpful.

[rubencm]

The commit should be like this

[ticket/17097] Fix PHP 8.2 deprecation warnings

PHPBB3-17097

[m-ober]

@rubencm Thanks, fixed.

[marc1706]

Thanks for your contribution 👍