[ticket/16470] Update user last visit time on session begin #6490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update user last visit time on session begin same way as on session create. PHPBB3-16470 PHPBB3-14173
PHPBB3-16470 PHPBB3-14173
PHPBB3-16470 PHPBB3-14173
Previous logic doesn't work correctly as session_time value got updated in regular manner, so that its 60 seconds lag with time_now can be unreachable in some cases. So update user_lastvisit if it lags for 60 sec of session_time. PHPBB3-16470 PHPBB3-14173
PHPBB3-16470 PHPBB3-14173
… time PHPBB3-16470 PHPBB3-14173
…tivity session_time has not been updated during session_length, so relying on it last activity data will be incorrect, especially if session_length value is high. Thus rely on regular and properly updated user_lastvisit. Remove user_lastvisit vs with session_time sync for the same reason. Also get rid of the session_last_visit field as it floats between user_lastvisit and session_time and actually is meaningless. PHPBB3-16470 PHPBB3-14173
PHPBB3-16470 PHPBB3-14173
This reverts changes made by last 2 commits as they seem to break things. PHPBB3-16470
marc1706
reviewed
Oct 31, 2023
marc1706
reviewed
Oct 31, 2023
phpBB/phpbb/db/migration/data/v33x/update_user_lastvisit_data.php
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
PHPBB3-16470.