Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change static to private variable due to php81 inheritance #6491

Merged
merged 1 commit into from Jun 21, 2023
Merged

Change static to private variable due to php81 inheritance #6491

merged 1 commit into from Jun 21, 2023

Conversation

im4bb
Copy link
Contributor

@im4bb im4bb commented Jun 14, 2023 •
edited by marc1706

Checklist:

  • Correct branch: master for new features; 3.3.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.3.x
  • Commit follows commit message format

https://tracker.phpbb.com/browse/PHPBB3-17145

@marc1706 marc1706 added this to the 3.3.11 milestone Jun 21, 2023
@marc1706
Copy link
Member

Cleaned up the commit message

marc1706
marc1706 approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@marc1706 marc1706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍

@marc1706 marc1706 merged commit bf50c63 into phpbb:3.3.x Jun 21, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc1706 marc1706 marc1706 approved these changes

Assignees
No one assigned
Labels
3.3 (Proteus) 🌑
Projects
None yet
Milestone
3.3.11
2 participants
@im4bb @marc1706