Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ticket/17151] Adjust form macros to adhere to coding guidelines #6496

Merged
merged 1 commit into from
Jul 30, 2023
Merged

[ticket/17151] Adjust form macros to adhere to coding guidelines #6496

merged 1 commit into from
Jul 30, 2023

Conversation

marc1706
Copy link
Member

@marc1706 marc1706 commented Jun 25, 2023 •
edited

PHPBB3-17151

Checklist:

  • Correct branch: master for new features; 3.3.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.3.x
  • Commit follows commit message format

Tracker ticket:

https://tracker.phpbb.com/browse/PHPBB3-17151

@marc1706 marc1706 added this to the 4.0.0-a1 milestone Jun 25, 2023
hanakin
hanakin approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@hanakin hanakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@marc1706 marc1706 merged commit 92d1af4 into phpbb:master Jul 30, 2023
37 checks passed
@marc1706 marc1706 deleted the ticket/17151 branch July 30, 2023 06:50
@rxu
Copy link
Contributor

rxu commented Sep 6, 2023

It'd be nice to have it documented about its use, especially together with the function build_cfg_template for ACP modules. Currently "old" style extensions code display Array instead of options in ACP modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanakin hanakin hanakin approved these changes

Assignees
No one assigned
Labels
4.0 (Triton) 🔮
Projects
None yet
Milestone
4.0.0-a1
3 participants
@marc1706 @rxu @hanakin