Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ticket/15687] Add attachment filename to attachment URL #6500

Merged
merged 5 commits into from
Jul 26, 2023
Merged

[ticket/15687] Add attachment filename to attachment URL #6500

merged 5 commits into from
Jul 26, 2023

Conversation

marc1706
Copy link
Member

@marc1706 marc1706 commented Jun 27, 2023 •
edited
Loading

This will also fix the invalid requirements for the file parameter of the URL.

PHPBB3-15687

Checklist:

  • Correct branch: master for new features; 3.3.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.3.x
  • Commit follows commit message format

Tracker ticket:

https://tracker.phpbb.com/browse/PHPBB3-15687

@marc1706
[ticket/15687] Add attachment filename to attachment URL
df6ab1a 
This will also fix the invalid requirements for the file parameter of the URL.

PHPBB3-15687
@marc1706 marc1706 added this to the 4.0.0-a1 milestone Jul 26, 2023
@marc1706 marc1706 mentioned this pull request Jul 26, 2023
Closed
4 tasks
@marc1706 marc1706 merged commit 1712ee6 into phpbb:master Jul 26, 2023
37 checks passed
@marc1706 marc1706 deleted the ticket/15687 branch July 26, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubencm rubencm rubencm approved these changes

Assignees
No one assigned
Labels
4.0 (Triton) 🔮
Projects
None yet
Milestone
4.0.0-a1
2 participants
@marc1706 @rubencm