Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ticket/13276] Support PHPBB_USE_BOARD_URL_PATH in web root path #6501

Merged
merged 1 commit into from
Aug 6, 2023
Merged

[ticket/13276] Support PHPBB_USE_BOARD_URL_PATH in web root path #6501

merged 1 commit into from
Aug 6, 2023

Conversation

marc1706
Copy link
Member

@marc1706 marc1706 commented Jun 30, 2023 •
edited
Loading

PHPBB3-13276

Checklist:

  • Correct branch: master for new features; 3.3.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.3.x
  • Commit follows commit message format

Tracker ticket:

https://tracker.phpbb.com/browse/PHPBB3-13276

@marc1706 marc1706 added this to the 3.3.11 milestone Jun 30, 2023
@marc1706 marc1706 mentioned this pull request Jun 30, 2023
Merged
4 tasks
Nicofuma
Nicofuma approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@Nicofuma Nicofuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember that last time I worked on this it was tricky with a lot of edge case ^^ Hope it simplifies everything and works better :)

@marc1706 marc1706 merged commit e5db724 into phpbb:3.3.x Aug 6, 2023
42 checks passed
@marc1706 marc1706 deleted the ticket/13276 branch August 6, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nicofuma Nicofuma Nicofuma approved these changes

Assignees
No one assigned
Labels
3.3 (Proteus) 🌑
Projects
None yet
Milestone
3.3.11
2 participants
@marc1706 @Nicofuma