-
-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS3 buttons #1075
CSS3 buttons #1075
Conversation
Looks good so far (mostly commenting so that I get notifications) |
CSS3 replacements for big buttons PHPBB3-10431
Different font for buttons on iOS devices because Verdana looks incorrectly aligned in Safari/iOS. Also slightly changed text shadow. PHPBB3-10431
Adjustments to buttons for IE7 PHPBB3-10431
Added backup fonts for Linux systems that do not have Verdana font PHPBB3-10431
display: inline-block; | ||
line-height: 16px; | ||
font-size: 13px; | ||
white-space: nowrap; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spacing seems kind of off in parts of your code.
What is the status here? What happened to nickvergessen's initial work? |
|
Is this still WIP? |
Yes, its still WIP |
Changing CSS for large buttons to display better on Mac browsers. Fixing tabs. PHPBB3-10431
Remove CSS for reply-all button that is no longer used PHPBB3-10431
Large buttons should be ready now. Please check it. What do you think about splitting small buttons (quote, edit, etc..) into separate PR? |
Remove .left class from .reply-all button PHPBB3-10431
If that will make it easier for you that is fine with me. I will try to test this more tonight on other browsers. |
Great. Removed WIP tag. So far I've tested it with Chrome and Firefox on Mac, Safari on iPod, default browser, Chrome, Firefox and Opera on Android. |
Whats up with the edit/quote icons? are they changed aswell? |
@nickvergessen Different PR. Tested in Chrome, FF, IE on Windows and they all looked correct. |
CSS3 replacements for buttons. This PR covers only large buttons, small buttons will be in separate PR
Ticket: http://tracker.phpbb.com/browse/PHPBB3-10431