-
-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ticket/8743] Include poster´s name in mail notifications #624
Conversation
@@ -2585,7 +2586,8 @@ function submit_post($mode, $subject, $username, $topic_type, &$poll, &$data, $u | |||
// Send Notifications | |||
if (($mode == 'reply' || $mode == 'quote' || $mode == 'post') && $post_approval) | |||
{ | |||
user_notification($mode, $subject, $data['topic_title'], $data['forum_name'], $data['forum_id'], $data['topic_id'], $data['post_id']); | |||
$username = ($username) ? $username : $user->data['username']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$username = $username ?: $user->data['username'];
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Olympus should work with php 4.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, didn't notice that
Looks good. |
…ympus * nickvergessen/ticket/8743: [ticket/8743] Include poster´s name in mail notifications
* develop-olympus: [ticket/8743] Include poster´s name in mail notifications
Tested with new topics in a watched forum, guests and registered posters. |
For a recent merge: phpbb/phpbb#624 PHPBB3-11103
http://tracker.phpbb.com/browse/PHPBB3-8743