[ticket/10949] Converted AJAX coding standards to new guidelines. #860
Conversation
Basically, moved parentheses to same line and changed variable names to camel case. PHPBB3-10949
|
Shouldn't be merged until after #759 has been. |
|
@callumacrae Where are these new guidelines? They are not in the coding standards document. If this is how the standards are supposed to be for JS and you update this PR, I will merge it. |
|
They're in the 3.1 coding guidelines. This PR is out of date now though |
|
I did not see them anywhere in http://area51.phpbb.com/docs/31x/coding-guidelines.html ? |
|
Dunno. It's in the coding guidelines in the repo: https://github.com/phpbb/phpbb3/blob/develop/phpBB/docs/coding-guidelines.html On 15 Dec 2012, at 18:56, Nathan Guse notifications@github.com wrote:
|
|
I see. If you update this PR I'll review and merge it. |
| if (typeof callback === 'function') | ||
| { | ||
| phpbb.ajax_callbacks[id] = callback; | ||
| phpbb.add_ajax_callback = function(id, callback) { |
There was a problem hiding this comment.
Shouldn't we also change phpbb.add_ajax_callback to phpbb.addAjaxCallback?
This typo was added by the PRs phpbb#860 and phpbb#1178. Only the object el exists and is correct. Due to this the text of links using the alt_text callback were not modified while executing the callback. PHPBB3-11313
This typo was added by the PRs phpbb#860 and phpbb#1178. Only the object el exists and is correct. Due to this the text of links using the alt_text callback were not modified while executing the callback. PHPBB3-11313
http://tracker.phpbb.com/browse/PHPBB3-10949