Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

percent_diff() expression formatting #1008

Closed
tillkruss opened this issue Oct 8, 2022 · 0 comments · Fixed by #1010
Closed

percent_diff() expression formatting #1008

tillkruss opened this issue Oct 8, 2022 · 0 comments · Fixed by #1010

Comments

@tillkruss
Copy link
Contributor

It would be nice if the percent_diff() would also add thousand separators like everything else does, because 13026.5% is hard to read.
dantleech added a commit that referenced this issue Oct 15, 2022
@dantleech
Fix formatting of number with zero decimal precision
9be1c5c 
Fixes #1008
@dantleech dantleech mentioned this issue Oct 15, 2022
Merged
dantleech added a commit that referenced this issue Oct 15, 2022
@dantleech
Fix formatting of number with zero decimal precision (#1010)
e4d26d1 
* Fix formatting of number with zero decimal precision

Fixes #1008

* Update CL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix formatting of number with zero decimal precision phpbench/phpbench
1 participant
@tillkruss