Fixed parenthesis for NOT negator

phpcr · Sep 11, 2014 · 4b92eda · 4b92eda
1 parent cdb41ce
commit 4b92eda
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/src/PHPCR/Util/QOM/BaseSqlGenerator.php b/src/PHPCR/Util/QOM/BaseSqlGenerator.php
@@ -83,7 +83,7 @@ public function evalOr($constraint1, $constraint2)
      */
     public function evalNot($constraint)
     {
-        return "NOT $constraint";
+        return "(NOT $constraint)";
     }
 
     /**

diff --git a/tests/PHPCR/Tests/Util/QOM/BaseSqlGeneratorTest.php b/tests/PHPCR/Tests/Util/QOM/BaseSqlGeneratorTest.php
@@ -0,0 +1,15 @@
+<?php
+
+namespace PHPCR\Tests\Util\QOM;
+
+use PHPCR\Util\QOM\Sql1Generator;
+use PHPCR\Util\ValueConverter;
+
+abstract class BaseSqlGeneratorTest extends \PHPUnit_Framework_TestCase
+{
+    public function testNot()
+    {
+        $string = $this->generator->evalNot("foo = bar");
+        $this->assertSame("(NOT foo = bar)", $string);
+    }
+}
diff --git a/tests/PHPCR/Tests/Util/QOM/Sql2GeneratorTest.php b/tests/PHPCR/Tests/Util/QOM/Sql2GeneratorTest.php
@@ -5,7 +5,7 @@
 use PHPCR\Util\QOM\Sql2Generator;
 use PHPCR\Util\ValueConverter;
 
-class Sql2GeneratorTest extends \PHPUnit_Framework_TestCase
+class Sql2GeneratorTest extends BaseSqlGeneratorTest
 {
     protected $generator;