properly use the cli helper #74
Conversation
|
once this is sorted out, we might also need to update the DoctrinePHPCRBundle and both jackalope cli-config.php.dist |
|
ups so the tests are not set up correctly. but if we merge the two helpers i don't need to look into that. |
|
Yeah.. so we instantiate the Helper manually because it needs to be present when the The https://github.com/doctrine/DoctrinePHPCRBundle/blob/master/Command/DoctrineCommandHelper.php We cannot move the logic into the There is also no way to automatically insert "helpers" into commands, for example, with DI - so thats why I instantiate it manually, and also I think why the "dump" helper was instantiated manually too. |
|
i will look into this in the context of the sandbox then and try to clean all this up. the DoctrineCommandHelper indeed looks rather scary. |
|
ping |
|
i did not get around to do this. and i won't have time today i fear, so lets tag without the fix. @dantleech did a quickfix last week to make the commands instantiate some helpers on the fly so at least it usually works now. for when i get to do it: what is the sane way for symfony commands to get their helpers? is there some listener or something we can use, or is the funny static call to a helper the only way to do this? |
|
@wouterj suggested that I make a PR to Symfony to enable helpers to be registered via. DI. At the moment the only way to register helpers AFAIK is to add them manually the Application. |
|
ping |
Conflicts: src/PHPCR/Util/Console/Command/BaseCommand.php
|
resurrected this, and cleaned up everything. the adjustments in phpcr-odm and phpcr-bundle are minimal, but i think there is some BC break in the setup, so i up the version to 1.1 here. |
|
@dantleech no objections from my side .. lets merge? |
| @@ -116,7 +117,7 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
| $parentPath | |||
| )); | |||
|
|
|||
| return; | |||
| return 2; | |||
There was a problem hiding this comment.
a non 0 return code of a linux binary means an error state. i just counted up the return statements so a calling programm could distinguish the states if it cares.
|
Looks good to me. |
we should not create an instance of the phpcr_cli helper manually. i wonder why we even have both PhpcrHelper and PhpcrCliHelper - can we just merge the additional functionality into PhpcrHelper instead? /cc @dantleech