Commits on Apr 28, 2012

1. Fixed notice-level PHP error in help.php: Notice: Undefined variable:… …

   … f in ~\help.php on line 19
   
   This was due to an incorrect variable name being used (copy/paste error).
   
   Issue logged, with patch file, at ProjectPier site: http://www.projectpier.org/node/3243

   

   MarkMaldaba committed Apr 28, 2012
   Configuration menu

   • View commit details
   • Copy full SHA for 3206c9f
   • Browse repository at this point

   Copy the full SHA

   3206c9f View commit details

   Browse the repository at this point in the history

2. Fixed another notice-level PHP error in help.php: Notice: Undefined v… …

   …ariable: d in ~\help.php on line 33
   
   This was due to an incorrect variable name being used (copy/paste error).
   
   Patch file added to existing issue at ProjectPier site: http://www.projectpier.org/node/3243

   

   MarkMaldaba committed Apr 28, 2012
   Configuration menu

   • View commit details
   • Copy full SHA for b7dca9d
   • Browse repository at this point

   Copy the full SHA

   b7dca9d View commit details

   Browse the repository at this point in the history

3. In the check_directory() and check_file() functions in help.php, ther… …

   …e are a bunch of checks that will fail with a PHP notice if the file/directory doesn't exist. Also, checks such as whether the file is readable are a bit meaningless for non-existent items.
   
   This commit updates the functions so that they bail out after the first test if the item does not exist. This avoids the PHP errors and meaningless information that is otherwise displayed.
   
   Logged as an issue at ProjectPier, with patch file attached: http://www.projectpier.org/node/3244

   

   MarkMaldaba committed Apr 28, 2012
   Configuration menu

   • View commit details
   • Copy full SHA for 107cd39
   • Browse repository at this point

   Copy the full SHA

   107cd39 View commit details

   Browse the repository at this point in the history